Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FuturePoolJavaFutureConverter is not compatible w/ twitter-util 19.1.0 #283

Open
jcohen opened this issue Jan 17, 2019 · 2 comments
Open

FuturePoolJavaFutureConverter is not compatible w/ twitter-util 19.1.0 #283

jcohen opened this issue Jan 17, 2019 · 2 comments

Comments

@jcohen
Copy link
Contributor

jcohen commented Jan 17, 2019

This commit in twitter-util removed NonFatal from com.twitter.util in favor of the version from scala.util.control.

Unfortunately FuturePoolJavaFutureConverter (and perhaps other places as well) relies on the version from com.twitter.util (which no longer exists) leading to NoClassDefFoundError exceptions at runtime.
@johnynek
Copy link
Collaborator

Happy to take a PR to update this.

@jcohen jcohen mentioned this issue Jan 17, 2019
Merged
@jcohen
Copy link
Contributor Author

jcohen commented Jan 18, 2019

Thanks for merging that @johnynek! Would it be possible to push a release with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnynek @jcohen