Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sandbox for methods #1950

Open
wants to merge 2 commits into
base: 1.x
Choose a base branch
from
Open

Fix sandbox for methods #1950

wants to merge 2 commits into from

Conversation

hason
Copy link
Contributor

@hason hason commented Dec 30, 2015 •
edited
Loading

Fixes:

  • Configure sandbox for method __call.
  • Call enabled method with name same as property.

stof
stof reviewed Dec 30, 2015
View reviewed changes
lib/Twig/Template.php Outdated
@@ -573,6 +576,10 @@ protected function getAttribute($object, $item, array $arguments = array(), $typ
$method = (string) $item;
$call = true;
} else {
if (isset($propertySandboxException)) {
throw $propertySandboxException;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this go after the $isDefinedTest condition ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed.

@hason hason force-pushed the policy branch 2 times, most recently from e20380f to ebb14a3 Compare January 20, 2016 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hason @stof @linaori