Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(n-modal): aria-hidden causes an error in the Chrome console #6463

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(n-modal): aria-hidden causes an error in the Chrome console #6463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.en-US.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
### Fixes

- Fix `n-time-picker`'s `use-12-hours` type error warning, closes [#4308](https://github.com/tusen-ai/naive-ui/issues/4308)
- Fix `n-modal` `aria-hidden` causes an error in the Chrome console, closes [#6436](https://github.com/tusen-ai/naive-ui/issues/6436)

### Features

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.zh-CN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
### Fixes

- `n-time-picker` 的 `use-12-hours` 类型错误警告，关闭 [#4308](https://github.com/tusen-ai/naive-ui/issues/4308)
- `n-modal` 导致 Chrome 控制台中出现错误，关闭 [#4308](https://github.com/tusen-ai/naive-ui/issues/4308)

### Features

Expand Down
2 changes: 1 addition & 1 deletion src/modal/src/Modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ export default defineComponent({
default: () => {
return this.show ? (
<div
aria-hidden
inert
ref="containerRef"
class={`${mergedClsPrefix}-modal-mask`}
onClick={this.handleClickoutside}
Expand Down
Loading