From b0768596d2f7b2c12aa61d8a9714325284410b4b Mon Sep 17 00:00:00 2001 From: Stephen Morton Date: Mon, 9 Dec 2024 18:26:34 -0800 Subject: [PATCH] correct parameter name for sock_recv of BaseEventLoop subclasses (#13212) --- stdlib/@tests/stubtest_allowlists/common.txt | 2 -- stdlib/asyncio/proactor_events.pyi | 1 + stdlib/asyncio/selector_events.pyi | 2 ++ 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/stdlib/@tests/stubtest_allowlists/common.txt b/stdlib/@tests/stubtest_allowlists/common.txt index acff6703b57d..7f80b6cbab40 100644 --- a/stdlib/@tests/stubtest_allowlists/common.txt +++ b/stdlib/@tests/stubtest_allowlists/common.txt @@ -288,8 +288,6 @@ ast.Str.__new__ # runtime is *args, **kwargs due to a wrapper, but we have more ast.NodeVisitor.visit_\w+ # Methods are discovered dynamically, see #3796 _?asyncio.Future.__init__ # Usually initialized from c object asyncio.futures.Future.__init__ # Usually initialized from c object -asyncio.proactor_events.BaseProactorEventLoop.sock_recv # nbytes parameter has different name 'n' in implementation -asyncio.selector_events.BaseSelectorEventLoop.sock_recv # nbytes parameter has different name 'n' in implementation # Condition functions are exported in __init__ asyncio.Condition.acquire diff --git a/stdlib/asyncio/proactor_events.pyi b/stdlib/asyncio/proactor_events.pyi index 957fdd6ce255..909d671df289 100644 --- a/stdlib/asyncio/proactor_events.pyi +++ b/stdlib/asyncio/proactor_events.pyi @@ -62,3 +62,4 @@ class _ProactorSocketTransport(_ProactorReadPipeTransport, _ProactorBaseWritePip class BaseProactorEventLoop(base_events.BaseEventLoop): def __init__(self, proactor: Any) -> None: ... + async def sock_recv(self, sock: socket, n: int) -> bytes: ... diff --git a/stdlib/asyncio/selector_events.pyi b/stdlib/asyncio/selector_events.pyi index 430f2dd405cd..18c5df033e2f 100644 --- a/stdlib/asyncio/selector_events.pyi +++ b/stdlib/asyncio/selector_events.pyi @@ -1,4 +1,5 @@ import selectors +from socket import socket from . import base_events @@ -6,3 +7,4 @@ __all__ = ("BaseSelectorEventLoop",) class BaseSelectorEventLoop(base_events.BaseEventLoop): def __init__(self, selector: selectors.BaseSelector | None = None) -> None: ... + async def sock_recv(self, sock: socket, n: int) -> bytes: ...