Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat throttling errors as retriable #1696

Open
richardartoul opened this issue Jun 9, 2024 · 0 comments
Open

Treat throttling errors as retriable #1696

richardartoul opened this issue Jun 9, 2024 · 0 comments

Comments

@richardartoul
Copy link

Describe the bug
kafkajs doesn't currently know about throttling errors and therefore treats them as unretriable, but they should be treated as retriable. These error codes are used by different kafka providers (my company included) to indicate that a client is doing too much of specific dimensions.

To Reproduce
N.A

Expected behavior
Client treats error as retriable.

Observed behavior
Client complains about a non-retriable error

(not showing full stack trace because it contains some identifiable information)

KafkaJSProtocolError: Unknown error code 89

 {
  retriable: false,
  helpUrl: undefined,
  type: 'KAFKAJS_UNKNOWN_ERROR_CODE',
  code: -99
}

Environment:

  • KafkaJS version [v2.2.4]

Fix: #1695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant