Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use typing in examples #184

Open
ttu opened this issue Sep 6, 2022 · 3 comments
Open

Use typing in examples #184

ttu opened this issue Sep 6, 2022 · 3 comments

Comments

@ttu
Copy link
Owner

ttu commented Sep 6, 2022

Most of the examples are missing type hints.
https://github.com/ttu/ruuvitag-sensor/tree/master/examples

No need to fix all examples in a single PR, but adding typing even to a single example is already a great help!

Example of PR where typing is added to 2 example files: #260

@chandu-jadhav
Copy link

Hey , can I work on this issue?

@ttu
Copy link
Owner Author

ttu commented Sep 7, 2022

@chandu-jadhav Sure!

As mentioned in the description, no need to add typing to all examples at once in a single PR, but you can modify one example, create a PR and ask for feedback.

Let me know if you have some questions.

@ttu
Copy link
Owner Author

ttu commented Jan 15, 2023

This issue is still available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants