From c5dbf6a929689a620c8f6a6b4b97825c038ce636 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Trygve=20Laugst=C3=B8l?= Date: Fri, 15 Feb 2013 17:20:04 +0100 Subject: [PATCH] o Implementing filtering for rpm and pkg. The pkg part is not very well tested yet. Should fix issue #1. --- TODO.txt | 4 + pom.xml | 7 +- .../org/codehaus/mojo/unix/UnixFileMode.java | 3 +- .../org/codehaus/mojo/unix/UnixPackage.java | 10 +- .../mojo/unix/core/FilterFilesOperation.java | 4 +- .../mojo/unix/core/FsFileCollector.java | 35 ++++--- unix-maven-plugin/pom.xml | 17 ++++ .../src/it/test-deb-1/pom4test.xml | 0 .../src/it/test-rpm-1/pom4test.xml | 5 + .../src/it/test-rpm-1/postbuild.groovy | 2 + .../files/opt/hudson/etc}/config.properties | 0 .../src/it/test-sysvpkg-1/postbuild.groovy | 4 +- .../src/it/test-sysvpkg-2/postbuild.groovy | 4 +- .../src/it/test-sysvpkg-3/postbuild.groovy | 6 +- .../it/test-sysvpkg-classes/postbuild.groovy | 5 +- .../codehaus/mojo/unix/maven/MojoHelper.java | 25 ++--- .../unix/maven/deb/DebPackagingFormat.java | 2 +- .../mojo/unix/maven/deb/DebUnixPackage.java | 53 +++++----- .../plugin/AbstractPackageAttachedMojo.java | 2 +- .../maven/plugin/AbstractPackageMojo.java | 2 +- .../mojo/unix/maven/plugin/FilterFiles.java | 1 - .../maven/plugin/PackageDebAttachedMojo.java | 3 +- .../unix/maven/plugin/PackageDebMojo.java | 4 +- .../maven/plugin/PackageRpmAttachedMojo.java | 2 +- .../unix/maven/plugin/PackageRpmMojo.java | 2 +- .../plugin/PackageSysvPkgAttachedMojo.java | 4 +- .../unix/maven/plugin/PackageSysvPkgMojo.java | 1 - .../unix/maven/plugin/PackageZipMojo.java | 2 +- .../unix/maven/rpm/RpmPackagingFormat.java | 7 +- .../mojo/unix/maven/rpm/RpmUnixPackage.java | 55 ++++++----- .../unix/maven/sysvpkg/PkgUnixPackage.java | 99 ++++++++++--------- .../maven/sysvpkg/SysvPkgPackagingFormat.java | 10 +- .../unix/maven/zip/ZipPackagingFormat.java | 15 +-- .../mojo/unix/maven/zip/ZipUnixPackage.java | 48 +++++---- .../mojo/unix/maven/UnixPackageTestUtil.java | 83 ++++++++++++++++ .../unix/maven/deb/DebUnixPackageTest.java | 56 ++++------- .../unix/maven/pkg/PkgUnixPackageTest.java | 21 ++++ .../mojo/unix/maven/plugin/ShittyUtil.java | 8 +- .../unix/maven/rpm/RpmUnixPackageTest.java | 27 ++++- .../mojo/unix/maven/zip/ZipPackageTest.java | 7 +- .../test-filtering/config.properties | 1 + .../{PkginfoFile.java => Pkginfo.java} | 44 ++++----- .../mojo/unix/sysvpkg/PkginfoUtil.java | 10 +- ...{PkginfoFileTest.java => PkginfoTest.java} | 18 ++-- 44 files changed, 431 insertions(+), 287 deletions(-) mode change 100644 => 100755 TODO.txt mode change 100644 => 100755 pom.xml mode change 100644 => 100755 unix-common/src/main/java/org/codehaus/mojo/unix/UnixFileMode.java mode change 100644 => 100755 unix-common/src/main/java/org/codehaus/mojo/unix/UnixPackage.java mode change 100644 => 100755 unix-core/src/main/java/org/codehaus/mojo/unix/core/FilterFilesOperation.java mode change 100644 => 100755 unix-core/src/main/java/org/codehaus/mojo/unix/core/FsFileCollector.java mode change 100644 => 100755 unix-maven-plugin/pom.xml mode change 100644 => 100755 unix-maven-plugin/src/it/test-deb-1/pom4test.xml mode change 100644 => 100755 unix-maven-plugin/src/it/test-rpm-1/pom4test.xml mode change 100644 => 100755 unix-maven-plugin/src/it/test-rpm-1/postbuild.groovy rename unix-maven-plugin/src/{test/resources/deb => it/test-rpm-1/src/main/unix/files/opt/hudson/etc}/config.properties (100%) mode change 100644 => 100755 mode change 100644 => 100755 unix-maven-plugin/src/it/test-sysvpkg-1/postbuild.groovy mode change 100644 => 100755 unix-maven-plugin/src/it/test-sysvpkg-2/postbuild.groovy mode change 100644 => 100755 unix-maven-plugin/src/it/test-sysvpkg-3/postbuild.groovy mode change 100644 => 100755 unix-maven-plugin/src/it/test-sysvpkg-classes/postbuild.groovy mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/MojoHelper.java mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/deb/DebPackagingFormat.java mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/deb/DebUnixPackage.java mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/plugin/AbstractPackageAttachedMojo.java mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/plugin/AbstractPackageMojo.java mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/plugin/FilterFiles.java mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/plugin/PackageDebAttachedMojo.java mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/plugin/PackageDebMojo.java mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/plugin/PackageRpmAttachedMojo.java mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/plugin/PackageRpmMojo.java mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/plugin/PackageSysvPkgAttachedMojo.java mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/plugin/PackageSysvPkgMojo.java mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/plugin/PackageZipMojo.java mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/rpm/RpmPackagingFormat.java mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/rpm/RpmUnixPackage.java mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/sysvpkg/PkgUnixPackage.java mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/sysvpkg/SysvPkgPackagingFormat.java mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/zip/ZipPackagingFormat.java mode change 100644 => 100755 unix-maven-plugin/src/main/java/org/codehaus/mojo/unix/maven/zip/ZipUnixPackage.java create mode 100755 unix-maven-plugin/src/test/java/org/codehaus/mojo/unix/maven/UnixPackageTestUtil.java mode change 100644 => 100755 unix-maven-plugin/src/test/java/org/codehaus/mojo/unix/maven/deb/DebUnixPackageTest.java create mode 100755 unix-maven-plugin/src/test/java/org/codehaus/mojo/unix/maven/pkg/PkgUnixPackageTest.java mode change 100644 => 100755 unix-maven-plugin/src/test/java/org/codehaus/mojo/unix/maven/plugin/ShittyUtil.java mode change 100644 => 100755 unix-maven-plugin/src/test/java/org/codehaus/mojo/unix/maven/rpm/RpmUnixPackageTest.java mode change 100644 => 100755 unix-maven-plugin/src/test/java/org/codehaus/mojo/unix/maven/zip/ZipPackageTest.java create mode 100644 unix-maven-plugin/src/test/resources/test-filtering/config.properties rename unix-sysv-pkg/src/main/java/org/codehaus/mojo/unix/sysvpkg/{PkginfoFile.java => Pkginfo.java} (76%) mode change 100644 => 100755 mode change 100644 => 100755 unix-sysv-pkg/src/main/java/org/codehaus/mojo/unix/sysvpkg/PkginfoUtil.java rename unix-sysv-pkg/src/test/java/org/codehaus/mojo/unix/sysvpkg/{PkginfoFileTest.java => PkginfoTest.java} (86%) mode change 100644 => 100755 diff --git a/TODO.txt b/TODO.txt old mode 100644 new mode 100755 index 7eb9402d..747a005f --- a/TODO.txt +++ b/TODO.txt @@ -73,6 +73,10 @@ o Make sure the result of setLastModified is asserted o Make sure that timestamps are preserved for all assembly operations +o Perform all io operations (IOEffect's) in a thread pool for faster execution. + This might not be so easy for ZIP, but will be very useful for the other kinds that require copying of files to an + assembly area. + == Refactorings == == Functional Java == diff --git a/pom.xml b/pom.xml old mode 100644 new mode 100755 index 9372b63b..1fa457e7 --- a/pom.xml +++ b/pom.xml @@ -39,6 +39,7 @@ 3.0 3.0 + 2.5 2.3.1 2.5 2.5 @@ -127,6 +128,10 @@ + + maven-clean-plugin + ${version.maven-clean-plugin} + maven-compiler-plugin ${version.maven-compiler-plugin} @@ -169,8 +174,6 @@ maven-resources-plugin utf-8 - 1.5 - 1.5