From a000c90a4c72d19bea8981a309cd85d5866006f2 Mon Sep 17 00:00:00 2001 From: Timothy Leverett Date: Fri, 2 Aug 2024 12:54:26 -0400 Subject: [PATCH] Fix ResizeObserver.disconnect The mock `disconnect` method was clearing the collection of observed targets before attempting to remove those observed targets from the global state. This causes the collection to always be empty. This fix clears the global state before clearing the local collection of observed targets. --- src/mocks/resize-observer.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mocks/resize-observer.ts b/src/mocks/resize-observer.ts index 28b0c3a..43053c4 100644 --- a/src/mocks/resize-observer.ts +++ b/src/mocks/resize-observer.ts @@ -85,8 +85,6 @@ class MockedResizeObserver implements ResizeObserver { }; disconnect = () => { - this.observationTargets.clear(); - for (const node of this.observationTargets) { const targetObservers = state.targetObservers.get(node); @@ -100,6 +98,8 @@ class MockedResizeObserver implements ResizeObserver { } } } + + this.observationTargets.clear(); }; }