First commit. Module is in D8 structure #14
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laceysanderson
requested changes
Apr 15, 2021
There was a problem hiding this comment.
- Do not delete the License and the Readme. Furthermore, the Readme should be updated to reflect the Tripal Version and should follow the ND Genotypes module template.
- API's should be converted to Drupal services where it makes sense to do so. At a minimum, they should become class-based.
- Remove all .DS_Store files you've committed.
- RST files should use
.. code-block:: langcodenot.. code::for the reliable rendering of syntax colouring. - ensure you always have newlines at the bottom of a file.
- Setup automated testing on this repository as done in Tripal4
- Upgrade-info.html should not be committed.
api/color_scheme.inc
Outdated
| @@ -110,21 +109,19 @@ function tripald3_get_scheme_colors($scheme_id, $type, $scheme = array()) { | |||
| /** | |||
| * Register Color Schemes with Javascript | |||
| */ | |||
| function tripald3_register_colorschemes() { | |||
| function tripald3_register_colorschemes($default) { | |||
There was a problem hiding this comment.
This is a non-backwards compatible change to the API. You need to provide a default for $default to minimize changes needed for others to upgrade their modules.
api/color_scheme.inc
Outdated
| $jsSettings['tripalD3']['colorSchemes'][$id]['name'] = $scheme['name']; | ||
| $jsSettings['tripalD3']['colorSchemes'][$id]['quantitative'] = tripald3_get_scheme_colors($id, 'quantitative', $scheme); | ||
| $jsSettings['tripalD3']['colorSchemes'][$id]['categorical'] = tripald3_get_scheme_colors($id, 'categorical', $scheme); | ||
| $jsSettings['colorSchemes'][$id]['name'] = $scheme['name']; |
There was a problem hiding this comment.
Why did you drop the tripalD3 key here? This was a Drupal standard to reduce the chance of collisions in js settings between modules.
api/pedigree.inc
Outdated
| } | ||
|
|
||
| return $rels_to_restrict; | ||
| } |
There was a problem hiding this comment.
Should have a newline at the end of files.
Suggested change
| } | |
| } | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This PR has been created to show the status of the Tripal 4 upgrade of this module. It should be used for testing purposes!
The 9.x-2.x branch should NEVER be merged into the current master branch
Description
This PR will make Tripal D3 module compatible with Drupal 8.
Testing?
Before installing this module, it is important that the main library required is present in your libraries for external libraries.
https://github.com/d3/d3/releases/download/v3.5.14/d3.zip
Download D3, unpack to sites/all/assets/vendor/d3 directory.
Install and enable module.
At the moment, Tripal does not consolidate all Tripal extension modules under yoursite/admin/tripal/extension. To view configuration and demo page of this module, use the link below
yoursite/admin/tripal/extension/tripald3
Documentation has been updated.
Documentation on how to create simple pie, simple donut and multi-series donut has been revised to comply with Drupal 8 requirements. A completed module that show the final result of following the step by step guide can be enabled to view the outcome.
yoursite/mychart/simplepie,
yoursite/mychart/simpledonut,
yoursite/mychart/multiseriesdonut,
and
yoursite/admin/tripal/extension/tripald3 - This module implements a hook that will extend colour scheme (titled monochromatic).
See my_chart
Unit test.
A unit test (Browser Test) in Tests/src/Functional/ is available and can be executed using Drupal 8 in yoursite/admin/config/development/testing search for tripalD3 module.