Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blastx, tblastn, blastp forms #102

Open
laceysanderson opened this issue Mar 30, 2024 · 2 comments · Fixed by #107
Open

Update blastx, tblastn, blastp forms #102

laceysanderson opened this issue Mar 30, 2024 · 2 comments · Fixed by #107
Labels
bug - confirmed For issues where a maintainer has confirmed a bug exists. Group 2 - User Interface Any issue relating to the user interface overview + submission forms.

Comments

@laceysanderson
Copy link
Member

If you click on any blast program other than blastn, you get a WSOD error.

Specific links that cause error:
overview-nucleotide
overview-protein

Example of the error caused:
image

This is caused by missing services providing alterations for these forms. To fix we will use TripalBlastProgramBlastn as a template to upgrade the other forms from the previous version: blastx, tblastn, blastp.

@laceysanderson laceysanderson added bug - confirmed For issues where a maintainer has confirmed a bug exists. Group 2 - User Interface Any issue relating to the user interface overview + submission forms. labels Mar 30, 2024
@laceysanderson laceysanderson reopened this Apr 1, 2024
@laceysanderson
Copy link
Member Author

Keeping this open as the blastx, tblastn, blastp forms still need their advanced options and the ability to upload files is also broken. That said, I think the functionality that is there does work 🤔 although it's hard to tell because the result page and the blast submission job itself are broken 🙈

@laceysanderson laceysanderson changed the title Only Blastn is supported by user form Update blastx, tblastn, blastp forms May 4, 2024
@laceysanderson
Copy link
Member Author

More detail for how to finish the upgrade of these forms:

For each of the forms,

  1. Copy the form elements from the Tripal 3 version. The form elements are in the tripal_blast/includes/blast_ui.form_advanced_options.inc file, function matching the pattern blast_ui_BLASTPROGRAM_advanced_options_form where you replace BLASTPROGRAM with one of the three to be upgraded.
  2. Paste them into the $form_alter array in the formOptions() function of the associated Tripal 4 service. These services are found in the src/Services/ directory and include the Blast Program in their name.
  3. Go to the page for that blast program in your Tripal site where the code changes were made and confirm that they show up similarly to how they did in Tripal 3.

Notes

  • The validate and submit will also need to be transferred over but we will wait to do this until later as currently it is hard to confirm that has been done without error.
  • The blastn program has already been done so that can be used as an example.
  • The Tripal 3 code can be found here: tripal_blast/includes/blast_ui.form_advanced_options.inc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug - confirmed For issues where a maintainer has confirmed a bug exists. Group 2 - User Interface Any issue relating to the user interface overview + submission forms.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant