Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve stats reporting for group by operator #21925

Open
sopel39 opened this issue May 10, 2024 · 5 comments · May be fixed by #24015
Open

Improve stats reporting for group by operator #21925

sopel39 opened this issue May 10, 2024 · 5 comments · May be fixed by #24015
Assignees
@sug-ghosh
Labels
good first issue Good for newcomers performance

Comments

@sopel39
Copy link
Member

sopel39 commented May 10, 2024 •
edited
Loading

Similarly as in f46fd9c we could separately report hash lookups/updates and aggregations' accumulator updates to get more insight into query bottlenecks.

cc @dain @raunaqmorarka
@sug-ghosh
Copy link

I want to take this up, @sopel39 can you give more insight of this.

@sopel39
Copy link
Member Author

sopel39 commented May 24, 2024

I want to take this up, @sopel39 can you give more insight of this.

Sure go ahead. Take a look at commit f46fd9c. You can see that ScanFilterAndProjectOperator keeps projection and fitltering stats in PageProcessorMetrics, which are then returned as operator metrics. Similar approach could be applied for group by operator. We can measure performance of GroupByHash and Accumulator separately.

@sug-ghosh
Copy link

okay.

@piotrrzysko
Copy link
Member

@sug-ghosh are you working on this or planning to? If not, I'd be happy to take it on.

@uditvarshney
Copy link
Contributor

@sug-ghosh If you are not working on this the I would like to take it.

@piotrrzysko piotrrzysko linked a pull request Nov 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sug-ghosh sug-ghosh

Labels
good first issue Good for newcomers performance
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add metrics for Accumulator and GroupByHash piotrrzysko/trino
4 participants
@sopel39 @piotrrzysko @uditvarshney @sug-ghosh