Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tests to Faker connector #23911

Open
ebyhr opened this issue Oct 25, 2024 · 10 comments
Open

Add missing tests to Faker connector #23911

ebyhr opened this issue Oct 25, 2024 · 10 comments
Assignees
Labels
good first issue Good for newcomers test

Comments

@ebyhr
Copy link
Member

ebyhr commented Oct 25, 2024

Add tests for the following statements to TestFakerQueries

  • ALTER TABLE name RENAME TO
  • ALTER TABLE name SET PROPERTIES
  • COMMENT ON TABLE
  • COMMENT ON COLUMN
@ebyhr ebyhr added good first issue Good for newcomers test labels Oct 25, 2024
@InderParmar
Copy link

Hi, I am interested in working on this issue, can you please assign it to me, and is it possible for you to add the hacktoberfest label to this issue?

@nineinchnick
Copy link
Member

@InderParmar we don't have the hacktoberfest label here, but you can start working on it.

@kavyabala23
Copy link

Can I work on this issue?

@nineinchnick
Copy link
Member

@kavyabala23 you'd have to coordinate with @InderParmar, maybe you two can split up the work?

@kavyabala23
Copy link

okay.@InderParmar can we split that ? I can work on
ALTER TABLE name RENAME TO
ALTER TABLE name SET PROPERTIES

@InderParmar
Copy link

@kavyabala23 sure, go ahead!

@kavyabala23
Copy link

Hi @nineinchnick ,I have made a pull request .I have signed the Contributor License Agreement and mailed it .But still it is not allowing.

@ebyhr
Copy link
Member Author

ebyhr commented Oct 29, 2024

@kavyabala23 CLA is usually processed every 2 weeks. You can ignore the bot message for now.

@kavyabala23
Copy link

kavyabala23 commented Oct 29, 2024

okay.But few maven checks are not successful.How to rectify that.

@nineinchnick
Copy link
Member

It's best to get help on the Trino Slack. Post in the #dev channel, describing the errors you're getting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test
Development

No branches or pull requests

4 participants