Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict maximum amount of queries shown in UI when MySQL event listener is used #23886

Open
konovenski opened this issue Oct 24, 2024 · 2 comments

Comments

@konovenski
Copy link

konovenski commented Oct 24, 2024

When MySQL event listener is used and queries are persistent, the UI selector allows you to pick between showing 20, 50, 100 and all queries. The "all" option is problematic in this case, since it will return full content of "select * from trino_queries". There should be an option to disable that setting, or it should just be disabled by default when using the event listener

@Praveen2112
Copy link
Member

How about configuring query.max-history and query.min-expire-age to restrict the SELECT * FROM TRINO_QUERIES won't it reduce the load in the UI side ?

@konovenski
Copy link
Author

konovenski commented Oct 24, 2024

@Praveen2112 default value of query.max-history is 100, and looks like it is not affecting the mysql database. From what i understand it is only related to the cases when trino stores the queries on coordinator, not when persistence is used. We want to have a full query retention, but the console should not output all of them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants