Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpdateClientCommand options behavior #191

Open
v-m-i opened this issue Mar 30, 2020 · 0 comments · May be fixed by #192
Open

UpdateClientCommand options behavior #191

v-m-i opened this issue Mar 30, 2020 · 0 comments · May be fixed by #192
Labels
enhancement New feature or request

Comments

@v-m-i
Copy link

v-m-i commented Mar 30, 2020

I have noticed that UpdateClientCommand deletes options that were not sent and always activates client if deactivated flag was not sent.

Example:

bin/console trikoder:oauth2:create-client client test --grant-type client_credentials
bin/console trikoder:oauth2:update-client client --deactivated 
 => client now has active set to 0 and grants set to null (lost his client_credentials grant)
bin/console trikoder:oauth2:update-client client --scope test
 => client now has active set to 1, grants to null and scope to test

Expected end result for example above would be:
Client has active set to 0, grants to client_credentials and scope to test.
@v-m-i v-m-i linked a pull request Mar 30, 2020 that will close this issue
Open
@HypeMC HypeMC added the enhancement New feature or request label Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix UpdateClientCommand options v-m-i/oauth2-bundle
2 participants
@HypeMC @v-m-i