Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OpenId Connect #25

Closed
MichaelKubovic opened this issue Feb 6, 2019 · 6 comments · May be fixed by #114
Closed

Support for OpenId Connect #25

MichaelKubovic opened this issue Feb 6, 2019 · 6 comments · May be fixed by #114
Labels
enhancement New feature or request
Milestone

Comments

@MichaelKubovic
Copy link

Hello, there is already a decent implementation of OIDC support for the thephpleague/oauth2-server here https://github.com/steverhoades/oauth2-openid-connect-server

I'd be happy to work on a MR that integrates it as a optional dependency if it's something you'd consider to merge.

Also, I'd need #18 and related PRs merged in order to start, thanks!

@ajgarlag
Copy link
Contributor

ajgarlag commented Feb 6, 2019

I'm already working on adding support for OIDC on top of #18 but still not sure if it should be integrated here, or distributed in another bundle. You can see my feature/openid-connect branch in https://github.com/ajgarlag/oauth2-bundle/tree/feature/openid-connect.

@spideyfusion Are you interested in this feature?

@spideyfusion spideyfusion added the enhancement New feature or request label Feb 7, 2019
@MichaelKubovic
Copy link
Author

@ajgarlag continuing debate from #18 (comment)

Which event would you like to listen to, to trigger authentication?

@MichaelKubovic
Copy link
Author

Hi @ajgarlag, now when we have #18 merged for some time, would you like to create a PR for the OIDC? If you're busy I'd be happy to create a PR from my fork, which is mostly your code.

@easybi-hj
Copy link

Any updates on this?

@spideyfusion spideyfusion linked a pull request Apr 20, 2020 that will close this issue
@HypeMC HypeMC added this to the v3.2.0 milestone Apr 20, 2020
@DevNiko
Copy link

DevNiko commented Jan 29, 2021

@MichaelKubovic
Possibly is the this Bundle a solution for you. I have implemented it in my project. A Combination of Trikoder oAuth2 Server, Leage oAuth2 Server and the oauth2-openid-connect-server.
But notice, that the oauth2-openid-connect-server does not support the newest version of the Leage oAuth Server Bundle. Because of Breaking Changes.

@MichaelKubovic
Copy link
Author

MichaelKubovic commented Jan 29, 2021

Thank you @DevNiko. We decided to move integration closer to our project source as it was exhausting to maintain open-source fork with features we didn't need ourselves. Thanks for the bundle anyway, someone may find it useful.

edit: the link you provided does not seem to work for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants