Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor climate match function: use help-subfunctions #81

Closed
damianooldoni opened this issue Mar 14, 2022 · 1 comment
Closed

Refactor climate match function: use help-subfunctions #81

damianooldoni opened this issue Mar 14, 2022 · 1 comment
Assignees

Comments

@damianooldoni
Copy link
Collaborator

From #77:
Climate match function is way too long. Splitting in subfunctions will help readibility and debugging: future-you, the maintainer (that's me 😮 ) and anyone else trying to understand the workflow will be grateful. Notice that these subfunctions can be written in the same R file, just append them below the "main" function. For example, the leaflet part is clearly something you can put in a subfunction, isn't?

@damianooldoni
Copy link
Collaborator Author

I think we can close this issue as we will remove this function, see #122. The refactoring will be done in that package.

@damianooldoni damianooldoni closed this as not planned Won't fix, can't repro, duplicate, stale May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants