Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send - ReviewTransaction modal - scroll automatically past the 5th recipient #3414

Open
sorooris opened this issue Feb 16, 2021 · 1 comment
Assignees
Labels
feature Product related issue visible for end user

Comments

@sorooris
Copy link
Contributor

sorooris commented Feb 16, 2021

Describe the bug
6th and following addresses are not visible during the most important step in the Send process (on-screen to on-device address veirifcation in the ReviewTransaction modal)

Info:

  • Remembered Wallet: arbitrary (tested remembered hidden wallet)
  • Suite Version: any (tested 21.2.2 7e8958e)
  • Browser: any (tested Chromium 88.0.4324.150)
  • OS: any (tested NixOS 20.09)
  • Bridge: any (tested 2.0.28)
  • Firmware Version: any (tested model T 2.3.6 b19cbf67c)

Steps to reproduce:

  1. Navigate to Accounts -> arbitrary account with balance -> Send form,
  2. Add 5+ recipients, add arbitrary addresses and amount to send and confirm,
  3. Confirm first 5 addresses on device and observe.

Expected result:
Recipients are autofocused in a similar fashion they are when adding new ones in the Send form (screengrab below).

Actual result:
6th and following addresses stay in the list hidden and manual scroll is needed.

Screenshots:
ReviewTransaction modal - no autofocus, needs to be manually scrolled
modal-no-autoscroll
Auto-focus on next recipient
autoscroll

@sorooris sorooris added the bug Something isn't working as expected label Feb 16, 2021
@alex-jerechinsky alex-jerechinsky removed the bug Something isn't working as expected label Feb 18, 2021
@alex-jerechinsky alex-jerechinsky changed the title Send - ReviewTransaction modal - 6th+ recipient hidden, manual scroll needed Send - ReviewTransaction modal - follow scroll past the 5th recipient Feb 18, 2021
@alex-jerechinsky alex-jerechinsky changed the title Send - ReviewTransaction modal - follow scroll past the 5th recipient Send - ReviewTransaction modal - scroll automatically past the 5th recipient Feb 18, 2021
@alex-jerechinsky
Copy link
Member

alex-jerechinsky commented Oct 8, 2021

Leaving this in the product column for now so product team can decide whether we need such a feature.

@alex-jerechinsky alex-jerechinsky removed their assignment Oct 8, 2021
@hynek-jina hynek-jina added the feature Product related issue visible for end user label Dec 16, 2021
@hynek-jina hynek-jina removed the LOW label Jun 8, 2022
@dahaca dahaca self-assigned this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Product related issue visible for end user
Projects
Status: No status
Development

No branches or pull requests

5 participants