Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You don't need to acknowledge seed safety measures during onboarding #3158

Open
bosomt opened this issue Dec 9, 2020 · 8 comments
Open

You don't need to acknowledge seed safety measures during onboarding #3158

bosomt opened this issue Dec 9, 2020 · 8 comments
Assignees
@dahaca
Labels
feature Product related issue visible for end user onboarding Onboarding part for a new user/device QA NOK Issue doesn't pass the QA and some changes are needed.
Milestone
Github grooming

Comments

@bosomt
Copy link
Contributor

bosomt commented Dec 9, 2020

Describe the bug
You don't need to acknowledge seed safety measures during onboarding
You can just press Skip PIN button after your seed is displayed during creation of new wallet.
And i wouldn't expect Skip PIN button during seed backup but during PIN setup.

Info:

  • Suite Version: app, commit be4e3a3
  • OS: Windows 10
  • Firmware Version: 1.9.3 model One , revision public

Steps to reproduce:

  1. wipe T1 device
  2. proceed with backup of new wallet
  3. press Skip PIN when asked to confirm that your seed will be stored safely

Expected result:
You need to confirm that you will keep your seed safe
Actual result:
You don't need to confirm that you will keep your seed safe

Screenshots:
image
@bosomt bosomt added the bug Something isn't working as expected label Dec 9, 2020
@matejzak
Copy link

Onboarding is being redesigned, will be fixed in the new implementation.

@bosomt
Copy link
Contributor Author

bosomt commented Mar 24, 2021

New onborading in next release, issue obsolete.

@bosomt bosomt closed this as completed Mar 24, 2021
@bosomt
Copy link
Contributor Author

bosomt commented Apr 30, 2021

Present in neue-onboarding

Screenshot 2021-04-30 at 15 31 07

Info:

  • Suite version: web 21.5.0 (5d5073e)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:88.0) Gecko/20100101 Firefox/88.0
  • OS: MacIntel
  • Screen: 1440x900
  • Device: model One 1.9.3 regular

@bosomt bosomt reopened this Apr 30, 2021
@bosomt
Copy link
Contributor Author

bosomt commented Apr 30, 2021

Mind that this is only available when you skip backup and restart it from settings page.

  • you are asked to Create PIN even when you wanted to backup your seed

@matejzak matejzak assigned slowbackspace and unassigned matejzak May 9, 2021
@alex-jerechinsky alex-jerechinsky added Feature request feature Product related issue visible for end user and removed bug Something isn't working as expected labels May 26, 2021
@alex-jerechinsky
Copy link
Member

alex-jerechinsky commented May 26, 2021 •
edited
Loading

@matejzak please suggest how it should behave. Unable to skip unless you check all the boxes? Or perhaps change the copy in some way?

@bosomt
Copy link
Contributor Author

bosomt commented Feb 14, 2022

QA NOK

seed backup in Suite settings still using old design

obrazek

Info:

  • Suite version: desktop 22.2.1 (520802b)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/22.2.1 Chrome/94.0.4606.81 Electron/15.3.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1680x1050
  • Device: model 1 1.10.5 regular

@hynek-jina hynek-jina added the onboarding Onboarding part for a new user/device label Mar 8, 2022
@hynek-jina hynek-jina removed the MEDIUM label Jun 8, 2022
@dahaca dahaca assigned dahaca and unassigned matejzak Aug 28, 2022
@MiroslavProchazka
Copy link
Contributor

@bosomt is this still valid please? :)

@bosomt
Copy link
Contributor Author

bosomt commented Mar 6, 2024

Same result.
All you have to press X or Skip PIN

This only happens when you trigger backup from Settings and not during onboarding

image

Info:

  • Suite version: desktop 24.3.1 (e1bbd6e)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.3.1 Chrome/118.0.5993.129 Electron/27.0.4 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2B1 2.6.5 regular (revision 561a697481656a4933e40f200455b07b28b051fc)
  • Transport: BridgeTransport 2.0.33

@MiroslavProchazka MiroslavProchazka added this to the Github grooming milestone May 24, 2024
@matejkriz matejkriz added the QA NOK Issue doesn't pass the QA and some changes are needed. label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dahaca dahaca

Labels
feature Product related issue visible for end user onboarding Onboarding part for a new user/device QA NOK Issue doesn't pass the QA and some changes are needed.
Projects
Issues Suite
Status: No status
Milestone
Github grooming
Development

No branches or pull requests
8 participants
@matejkriz @slowbackspace @hynek-jina @matejzak @bosomt @dahaca @alex-jerechinsky @MiroslavProchazka