Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show latest commit hash somewhere on the page #36

Open
ricardoboss opened this issue Aug 16, 2022 · 1 comment
Open

Show latest commit hash somewhere on the page #36

ricardoboss opened this issue Aug 16, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ricardoboss
Copy link
Member

To aid in debugging a problem, it helps to know which commit was used when deploying the frontend. Including it should be trivial:

  • the Dockerfile can read the commit sha1 and store it in an env file (for example: VUE_APP_GIT_REF)
  • the Vue app can check if the variable is set and display it/include it somewhere in the frontend code (for example as a title attribute on the TRENZ logo, so it shows up when hovering over it)
@ricardoboss ricardoboss added the enhancement New feature or request label Aug 16, 2022
@ricardoboss ricardoboss added the good first issue Good for newcomers label Aug 25, 2022
@ricardoboss
Copy link
Member Author

To make this work, a script might need to access .git from within the docker container during build. To make this possible, this commit needs to be reverted: a0150d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant