Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TravisCi Web enterprise merge. #2814

Open
wants to merge 54 commits into
base: master
Choose a base branch
from
Open

Conversation

SebastianKarpetaDev
Copy link

No description provided.

DamianSzymanski and others added 30 commits March 18, 2021 21:13
* Security updates: rack-> 2.2.3
* Updated GitHubApps Management URL
* updated installation check
* security updates [ship:docker]
management link fix for installation without logout/login
* repo settings merge from master

* switch for pub repos
* upgrade-gems

* updating puma

* browserslist fix -v4

* ruby 2.7.5 for Dockerfile

* minimist 1.2.6

* removed silent in dockerfile

* build fix

Co-authored-by: Maciej <[email protected]>
Co-authored-by: gabriel-arc <[email protected]>
* gem updates

* ansiparse link fix
* merge disable-logs func from master

* ship:docker
Show manual builds and restarts (#2712) (#2718)
piccadilly-circus and others added 3 commits December 6, 2023 13:17
* skip random failing tests for now
* not closing trigger build dialog if clicked outside

* env/requests/repo tooltips

---------

Co-authored-by: GbArc <[email protected]>
@@ -35,7 +35,6 @@ export default Component.extend({
isMatchGithub: match('owner.vcsType', /Github\S+$/),
isOwnerVcsTypeEmpty: empty('owner.vcsType'),
isNotGithubRepository: not('isGithubRepository'),
hasGitHubAppsInstallation: notEmpty('owner.installation'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it removed?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goo question, probably merge issue. Exists on master. Done.

@@ -498,3 +498,12 @@ $env-var-value-background: lighten($cement-grey, 20);
margin-left: 20px;
}
}

.ember-tooltip {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will probably break some tooltips - don't add

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, but it's probably responsible for a tool tip added in enterpise .. but .. removed. Done.

@@ -146,6 +146,102 @@
</li>
</ul>
</section>
<section class="settings-section">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate? - check with the section above if there aren't any enterprise-only changes and put under a flag if so - if it's the same -> out

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a additionall condition:

{{#if (or this.features.enterpriseVersion this.repo.private)}}

@@ -1,4 +1,4 @@
import { module, test, skip } from 'qunit';
import { module, skip, test, skip } from 'qunit';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double skip

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -207,7 +207,8 @@ def set_config(string, _opts = {}) # rubocop:disable Metrics/CyclomaticComplexit
if options[:github_apps_app_name]
config['githubApps'] ||= {}
config['githubApps']['appName'] = options[:github_apps_app_name]
end
config['githubApps']['migrationRepositoryCountLimit'] = 50
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -291,40 +290,6 @@ module('Acceptance | profile/basic layout', function (hooks) {
await profilePage.visit();
});

test('view profiles for organizations that do not and do have GitHub Apps installations', async function (assert) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't remove, change to 'skip' for now

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -342,64 +307,6 @@ module('Acceptance | profile/basic layout', function (hooks) {
assert.notOk(profilePage.administerableRepositories[2].isActive, 'expected inactive repository to appear inactive');
});

test('view profile when GitHub Apps is present and no legacy repositories exist', async function (assert) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't remove, change to 'skip' for now

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -77,6 +77,28 @@ export default Component.extend({
}
}),

hasEmailSubscription: computed('repository', 'repository.emailSubscribed', function () {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate

Makefile Outdated
@@ -27,7 +27,7 @@ DOCKER ?= docker

.PHONY: docker-build
docker-build:
$(DOCKER) build -t $(DOCKER_DEST) .
$(DOCKER) build --pull --no-cache -t $(DOCKER_DEST) . -f Dockerfile.ycie
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ycie -> typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants