-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TravisCi Web enterprise merge. #2814
base: master
Are you sure you want to change the base?
Conversation
* Security updates: rack-> 2.2.3
* Updated GitHubApps Management URL * updated installation check
* security updates [ship:docker]
management link fix for installation without logout/login
* repo settings merge from master * switch for pub repos
* upgrade-gems * updating puma * browserslist fix -v4 * ruby 2.7.5 for Dockerfile * minimist 1.2.6 * removed silent in dockerfile * build fix Co-authored-by: Maciej <[email protected]> Co-authored-by: gabriel-arc <[email protected]>
* gem updates * ansiparse link fix
* merge disable-logs func from master * ship:docker
Co-authored-by: GbArc <[email protected]>
* skip random failing tests for now
* not closing trigger build dialog if clicked outside * env/requests/repo tooltips --------- Co-authored-by: GbArc <[email protected]>
@@ -35,7 +35,6 @@ export default Component.extend({ | |||
isMatchGithub: match('owner.vcsType', /Github\S+$/), | |||
isOwnerVcsTypeEmpty: empty('owner.vcsType'), | |||
isNotGithubRepository: not('isGithubRepository'), | |||
hasGitHubAppsInstallation: notEmpty('owner.installation'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goo question, probably merge issue. Exists on master. Done.
app/styles/app/layouts/settings.scss
Outdated
@@ -498,3 +498,12 @@ $env-var-value-background: lighten($cement-grey, 20); | |||
margin-left: 20px; | |||
} | |||
} | |||
|
|||
.ember-tooltip { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will probably break some tooltips - don't add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed, but it's probably responsible for a tool tip added in enterpise .. but .. removed. Done.
app/templates/settings.hbs
Outdated
@@ -146,6 +146,102 @@ | |||
</li> | |||
</ul> | |||
</section> | |||
<section class="settings-section"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate? - check with the section above if there aren't any enterprise-only changes and put under a flag if so - if it's the same -> out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a additionall condition:
{{#if (or this.features.enterpriseVersion this.repo.private)}}
@@ -1,4 +1,4 @@ | |||
import { module, test, skip } from 'qunit'; | |||
import { module, skip, test, skip } from 'qunit'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double skip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
waiter/lib/travis/web/app.rb
Outdated
@@ -207,7 +207,8 @@ def set_config(string, _opts = {}) # rubocop:disable Metrics/CyclomaticComplexit | |||
if options[:github_apps_app_name] | |||
config['githubApps'] ||= {} | |||
config['githubApps']['appName'] = options[:github_apps_app_name] | |||
end | |||
config['githubApps']['migrationRepositoryCountLimit'] = 50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@@ -291,40 +290,6 @@ module('Acceptance | profile/basic layout', function (hooks) { | |||
await profilePage.visit(); | |||
}); | |||
|
|||
test('view profiles for organizations that do not and do have GitHub Apps installations', async function (assert) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't remove, change to 'skip' for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@@ -342,64 +307,6 @@ module('Acceptance | profile/basic layout', function (hooks) { | |||
assert.notOk(profilePage.administerableRepositories[2].isActive, 'expected inactive repository to appear inactive'); | |||
}); | |||
|
|||
test('view profile when GitHub Apps is present and no legacy repositories exist', async function (assert) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't remove, change to 'skip' for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@@ -77,6 +77,28 @@ export default Component.extend({ | |||
} | |||
}), | |||
|
|||
hasEmailSubscription: computed('repository', 'repository.emailSubscribed', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate
Makefile
Outdated
@@ -27,7 +27,7 @@ DOCKER ?= docker | |||
|
|||
.PHONY: docker-build | |||
docker-build: | |||
$(DOCKER) build -t $(DOCKER_DEST) . | |||
$(DOCKER) build --pull --no-cache -t $(DOCKER_DEST) . -f Dockerfile.ycie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ycie -> typo
No description provided.