Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archiving error loop with Travis::Logs::Services::ArchiveLog::VerificationFailed #143

Open
meatballhat opened this issue Jul 17, 2017 · 0 comments
Assignees
Labels

Comments

@meatballhat
Copy link
Contributor

In the past few months, there has been a noticeable increase in the occurrence of Travis::Logs::Services::ArchiveLog::VerificationFailed, which is raised during log archiving when comparing the database log content with the S3 log content. This should happen rarely, if ever, as it is an indication that archiving was triggered prior to job completion. There is a tight retry loop inside the ArchiveLog service that I believe is not allowing for enough time to pass before raising an error and causing the job to go to sidekiq retry handling. Ideally, the sidekiq retry handling should be enough to ensure that the logs are eventually correctly archived, in which case we should consider:

  • stop sending these errors to sentry
  • send all sidekiq retries to sentry instead (?)
  • send one event to sentry after being sidekiq retried n number of times
  • something else?
meatballhat added a commit that referenced this issue Jul 17, 2017
and instead allow the errors to bubble up so that Sidekiq retries take
effect.

Addresses #143
@meatballhat meatballhat self-assigned this Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant