Remove gh gem

travis-ci · Dec 3, 2020 · d743d43 · d743d43
1 parent 9cff6fe
commit d743d43
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 14 deletions.
diff --git a/Gemfile b/Gemfile
@@ -31,7 +31,6 @@ gem 'activerecord'
 gem 'faraday'
 gem 'faraday_middleware'
 
-gem 'gh'
 gem 'keen'
 gem 'sentry-raven'
 gem 'simple_states', git: 'https://github.com/svenfuchs/simple_states'

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -113,13 +113,6 @@ GEM
       multipart-post (>= 1.2, < 3)
     faraday_middleware (0.12.2)
       faraday (>= 0.7.4, < 1.0)
-    gh (0.15.1)
-      addressable (~> 2.4.0)
-      backports
-      faraday (~> 0.8)
-      multi_json (~> 1.0)
-      net-http-persistent (~> 2.9)
-      net-http-pipeline
     hashdiff (0.3.0)
     hashr (2.0.0)
     hitimes (1.2.6)
@@ -147,8 +140,6 @@ GEM
       metaclass (~> 0.0.1)
     multi_json (1.12.1)
     multipart-post (2.0.0)
-    net-http-persistent (2.9.4)
-    net-http-pipeline (1.0.1)
     nio4r (2.5.2)
     pg (0.19.0)
     pry (0.11.3)
@@ -231,7 +222,6 @@ DEPENDENCIES
   factory_girl
   faraday
   faraday_middleware
-  gh
   jemalloc
   jwt
   keen

diff --git a/lib/travis/addons/serializer/tasks/build.rb b/lib/travis/addons/serializer/tasks/build.rb
@@ -64,7 +64,7 @@ def owner_data
             def repository_data
               {
                 id: repository.id,
-                github_id: repository.github_id,
+                github_id: repository.vcs_id,
                 vcs_id: repository.vcs_id,
                 vcs_type: repository.vcs_type,
                 key: repository.key.try(:public_key),

diff --git a/spec/travis/addons/serializer/generic/build_spec.rb b/spec/travis/addons/serializer/generic/build_spec.rb
@@ -1,6 +1,6 @@
 describe Travis::Addons::Serializer::Tasks::Build do
   let(:owner)  { FactoryGirl.create(:user, login: 'login') }
-  let(:repo)   { FactoryGirl.create(:repository, github_id: 12345, vcs_id: '12345', vcs_type: 'GithubRepository') }
+  let(:repo)   { FactoryGirl.create(:repository, vcs_id: '12345', vcs_type: 'GithubRepository') }
   let(:build)  { FactoryGirl.create(:build, owner: owner, repository: repo, pull_request: pull, tag: tag, jobs: [job]) }
   let(:stage)  { FactoryGirl.create(:stage, number: 1, name: 'example') }
   let(:job)    { FactoryGirl.create(:job, repository: repo, stage: stage) }
@@ -39,7 +39,7 @@
   it 'repository data' do
     expect(data[:repository]).to eql(
       id: repo.id,
-      github_id: 12345,
+      github_id: repo.vcs_id.to_i,
       vcs_id: '12345',
       vcs_type: 'GithubRepository',
       key: nil,