Skip to content

Commit d743d43

Browse files
author
Stanislav Kolotinskiy
committed
Remove gh gem
1 parent 9cff6fe commit d743d43

File tree

4 files changed

+3
-14
lines changed

4 files changed

+3
-14
lines changed

Gemfile

-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ gem 'activerecord'
3131
gem 'faraday'
3232
gem 'faraday_middleware'
3333

34-
gem 'gh'
3534
gem 'keen'
3635
gem 'sentry-raven'
3736
gem 'simple_states', git: 'https://github.com/svenfuchs/simple_states'

Gemfile.lock

-10
Original file line numberDiff line numberDiff line change
@@ -113,13 +113,6 @@ GEM
113113
multipart-post (>= 1.2, < 3)
114114
faraday_middleware (0.12.2)
115115
faraday (>= 0.7.4, < 1.0)
116-
gh (0.15.1)
117-
addressable (~> 2.4.0)
118-
backports
119-
faraday (~> 0.8)
120-
multi_json (~> 1.0)
121-
net-http-persistent (~> 2.9)
122-
net-http-pipeline
123116
hashdiff (0.3.0)
124117
hashr (2.0.0)
125118
hitimes (1.2.6)
@@ -147,8 +140,6 @@ GEM
147140
metaclass (~> 0.0.1)
148141
multi_json (1.12.1)
149142
multipart-post (2.0.0)
150-
net-http-persistent (2.9.4)
151-
net-http-pipeline (1.0.1)
152143
nio4r (2.5.2)
153144
pg (0.19.0)
154145
pry (0.11.3)
@@ -231,7 +222,6 @@ DEPENDENCIES
231222
factory_girl
232223
faraday
233224
faraday_middleware
234-
gh
235225
jemalloc
236226
jwt
237227
keen

lib/travis/addons/serializer/tasks/build.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def owner_data
6464
def repository_data
6565
{
6666
id: repository.id,
67-
github_id: repository.github_id,
67+
github_id: repository.vcs_id,
6868
vcs_id: repository.vcs_id,
6969
vcs_type: repository.vcs_type,
7070
key: repository.key.try(:public_key),

spec/travis/addons/serializer/generic/build_spec.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
describe Travis::Addons::Serializer::Tasks::Build do
22
let(:owner) { FactoryGirl.create(:user, login: 'login') }
3-
let(:repo) { FactoryGirl.create(:repository, github_id: 12345, vcs_id: '12345', vcs_type: 'GithubRepository') }
3+
let(:repo) { FactoryGirl.create(:repository, vcs_id: '12345', vcs_type: 'GithubRepository') }
44
let(:build) { FactoryGirl.create(:build, owner: owner, repository: repo, pull_request: pull, tag: tag, jobs: [job]) }
55
let(:stage) { FactoryGirl.create(:stage, number: 1, name: 'example') }
66
let(:job) { FactoryGirl.create(:job, repository: repo, stage: stage) }
@@ -39,7 +39,7 @@
3939
it 'repository data' do
4040
expect(data[:repository]).to eql(
4141
id: repo.id,
42-
github_id: 12345,
42+
github_id: repo.vcs_id.to_i,
4343
vcs_id: '12345',
4444
vcs_type: 'GithubRepository',
4545
key: nil,

0 commit comments

Comments
 (0)