-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reusable git builds #151
Open
philpennock
wants to merge
8
commits into
master
Choose a base branch
from
reusable_git_builds
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Reusable git builds #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a common git bare repo for fetching code, build from git in specific directories so that each is reusable. Cleans up some of the gunk/tech-debt I accrued earlier in version parsing. I _think_ this approach succeeds with everything the earlier approach did. This is part 1 of addressing #147 where I sketched out the design; no log-files yet.
This gives us the other part of multiple git builds, each isolated, per issue #147. Caveat: the use of aliases breaks the log-file's utility. For now, I'm handling that by not implementing aliases for git and constraining clean to be only for git. We can revisit if desired.
ping |
1 similar comment
ping |
Ping. |
Thanks for the continued pings @philpennock , we're merging a few other PRs and cutting a 1.5.2 release, and then we'll circle back to this for a 1.6.0 release in the coming weeks. cc/ @joepvd |
We want all references to auto-update, so --mirror is more appropriate. This fixes `gimme tip` being very stale.
I have shfmt v2.5.1 installed; it disagrees with shfmt v2.2.0 on how to normalize one line of this file, thus the tests passing. I've manually edited to what shfmt v2.2.0 apparently desires.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch implements the design which I sketched out in #147 to have reusable git builds, by splitting off the
.git
dir from the build dirs, and having a log of invocations to use with a newgimme clean
.Fixes #147