Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator does not match trailblazer concept conventions #33

Open
pmackay opened this issue Aug 11, 2017 · 3 comments
Open

Generator does not match trailblazer concept conventions #33

pmackay opened this issue Aug 11, 2017 · 3 comments

Comments

@pmackay
Copy link

pmackay commented Aug 11, 2017

The TRB 2.0 file layout suggests a file for each cell view mode and the templates go in /view. The current generator creates a cell.rb and a /views directory. Should the cell-rails generator be updated to match the TRB conventions?

@apotonick
Copy link
Member

Thanks Paul, I believe the generator now sits in https://github.com/trailblazer/trailblazer-generator !

@pmackay
Copy link
Author

pmackay commented Aug 14, 2017

Thanks for reply @apotonick, could you expand a bit on this? Are you suggesting that any generator functionality in this gem should be moved to trailblazer-generator? trailblazer-generator seems to be in WIP state, so is the dev focus on improving that rather than updating any generator functionality here? Ultimately should the generator code from this gem be removed?

thanks!

@apotonick
Copy link
Member

Ultimately, we want to drop Cells ViewModel and Concept and only support Trailblazer::Cell - which means that... we somehow would've to merge/reference... uhm....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants