Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: list disallowed packages (like "unsafe") #21

Open
Candinya opened this issue Mar 21, 2024 · 2 comments
Open

feature request: list disallowed packages (like "unsafe") #21

Candinya opened this issue Mar 21, 2024 · 2 comments
Labels
area/documentation Improvements or additions to documentation kind/enhancement a new or improved feature.

Comments

@Candinya
Copy link

We are writing a traefik plugin and when it's almost done, the local test indicates that package "unsafe" used by one of our dependency cannot be loaded ( import "unsafe" error: unable to find source related to: "unsafe" ). During the debugging we found issues like traefik/traefik#7459 or traefik/traefik#8844 . With no luck finding solutions, we realize that we have to change the fundamental dependence (in this case, we are using twmb/franz-go to communicate with kafka) .

So, as a kind reminder, what about listing the unsupported packages in this repository's readme (may also in the document), so other developers can review their dependencies before falling into such awkward situations? Thanks 🙏

@nmengin
Copy link

nmengin commented Oct 10, 2024

Hey @Candinya ,

Thanks for reaching out.

We agree that it makes a lot of sense to add this information in the README.

Unfortunately, this would not make it to our roadmap for a while as we are focused elsewhere.

If you or another community member would like to build it, let us know, and we will work with you to make sure you have all the information needed so that it can be merged.

@nmengin nmengin added kind/enhancement a new or improved feature. area/documentation Improvements or additions to documentation labels Oct 10, 2024
@Candinya
Copy link
Author

Thanks for your kind reply!

Actually we solved this problem by splitting the service into different components, with a connector running unsupported packages to cooperate with traefik plugin, so those packages can be prevented from being introduced into the plugin itself directly, and then everything works as expected. Hope this solution can provide some help to others who were facing the same situation.

Thanks for your contribution to such a wonderful project ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation kind/enhancement a new or improved feature.
Projects
None yet
Development

No branches or pull requests

2 participants