Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessions not being created - cannot login to website #83

Open
jonom opened this issue Feb 8, 2019 · 2 comments
Open

Sessions not being created - cannot login to website #83

jonom opened this issue Feb 8, 2019 · 2 comments

Comments

@jonom
Copy link
Contributor

jonom commented Feb 8, 2019

Running master on SS3.7 / PHP5.6 I'm unable to login to the website. Reverting this commit seems to fix the issue. I tried to follow the code and understand why this is the case but I couldn't work it out 🤷‍♂️. As noted in the pull request it would seem to follow the same pattern as main.php but seems something is getting lost along the way.

To replicate, make sure dynamic caching is activated in .htaccess, delete cookies for the website (if PHPSESSID exists already login will work), then try to access a protected URL like /admin. After filling out the log in form I'm simply redirected back to the same form, unfilled.

@mlewis-everley
Copy link

I can confirm that I am seeing this as well on a SS 3.7 / PHP 7.1 install.

@tractorcow
Copy link
Owner

We can revert that commit maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants