From 17737841ee8f8b097f3a356f88a0ffeba0d19297 Mon Sep 17 00:00:00 2001 From: syl20bnr Date: Mon, 9 Dec 2024 13:37:38 -0500 Subject: [PATCH] Minor tweaks to build.rs --- crates/cubecl-hip-sys/build.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/crates/cubecl-hip-sys/build.rs b/crates/cubecl-hip-sys/build.rs index 671716b..2b75394 100644 --- a/crates/cubecl-hip-sys/build.rs +++ b/crates/cubecl-hip-sys/build.rs @@ -58,7 +58,6 @@ fn get_rocm_feature_version() -> io::Result<(u8, u8, u32)> { for (key, value) in env::vars() { if key.starts_with(ROCM_FEATURE_PREFIX) && value == "1" { if let Some(version) = key.strip_prefix(ROCM_FEATURE_PREFIX) { - // Parse the version using `_` as the delimiter let parts: Vec<&str> = version.split('_').collect(); if parts.len() == 3 { if let (Ok(major), Ok(minor), Ok(patch)) = ( @@ -75,7 +74,7 @@ fn get_rocm_feature_version() -> io::Result<(u8, u8, u32)> { Err(io::Error::new( io::ErrorKind::NotFound, - "No valid ROCm feature version found. One 'rocm_' feature must be set.", + "No valid ROCm feature version found. One 'rocm__' feature must be set. For insance for ROCm 6.2.2 the feature is rocm__6_2_2.", )) }