Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow non-admins to see the comments list #15

Open
livedata opened this issue May 17, 2012 · 1 comment
Open

Allow non-admins to see the comments list #15

livedata opened this issue May 17, 2012 · 1 comment
Milestone
1.2.0

Comments

@livedata
Copy link

TRAC_ADMIN privileges are required to perform this operation. You don't have the required permissions.

I think that TICKET_CREATE and/or TICKET_VIEW should be enought to see code comments list... Or even better - additional permission type: CODE_COMMENTS_LIST
@nb
Copy link
Contributor

nb commented May 17, 2012

This makes perfect sense and it should get in the next version (added it to the 1.2.0 milestone).

I like the custom permissions idea better and I will implement it, unless you beat me to it :-)

Orio91 pushed a commit to Orio91/trac-code-comments-plugin that referenced this issue Aug 16, 2012
@ntesteca
Not heavily tested patch for trac-hacks#13 trac-hacks#14 and trac-hac…
383df5c 
…ks#15
Orio91 pushed a commit to Orio91/trac-code-comments-plugin that referenced this issue Sep 10, 2012
@ntesteca
Added new permission CODE_COMMENTS_LIST instead of TRAC_ADMIN. Fixes t…
a1c0543 
…rac-hacks#15
schwuk referenced this issue in schwuk/trac-code-comments-plugin Aug 4, 2014
@schwuk
Send notifications when comments are created
ee51e04 
Added a new interface - ICodeCommentChangeListener - to use for
notifications.

Added a new component - CodeCommentSystem - to act as the extension
point for the above interface. (This could have been added to one of the
other components, but I have plans for other refactorings and wanted a
clean base for them.)

Extended Comments.create() to trigger comment_created events.

Added a new component - CodeCommentChangeListener - to respond to
comment_created events.

Sub-classed trac.notification.NotifyEmail to generate notification
emails. Notifications are sent to the author of the resouce being
commented on, and anyone else who has commented on the same resource.
There is additional logic to determine who the notification should be
*sent* and *copied* to.

Added an option to control whether notifications are sent to the person
making the comment (off by default).

Removed unused variable.
@schwuk schwuk mentioned this issue Sep 30, 2014
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
1 participant
@nb