Skip to content

Commit dc2005a

Browse files
author
goodsign
committed
Avoid file creation\opening race in file writer.
1 parent 166672c commit dc2005a

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

writers_filewriter.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,7 @@ func (fw *fileWriter) createFile() error {
7878
}
7979

8080
// If exists
81-
_, err = os.Lstat(fw.fileName)
82-
if nil == err {
83-
fw.innerWriter, err = os.OpenFile(fw.fileName, os.O_WRONLY|os.O_APPEND, defaultFilePermissions)
84-
} else {
85-
fw.innerWriter, err = os.Create(fw.fileName)
86-
}
81+
fw.innerWriter, err = os.OpenFile(fw.fileName, os.O_WRONLY|os.O_APPEND|os.O_CREATE, defaultFilePermissions)
8782

8883
if err != nil {
8984
return err

0 commit comments

Comments
 (0)