Feedback

[tpeczek]

This issue is for general feedback regarding this project.

[theLeftTenant]

I read your walk-throughs and this seems like the most well maintained .Net Core Web Push tool. Any interest in strong naming the DLLs?

[tpeczek]

Thank you.

Regarding the strong naming, it has positive recommendation and negative aspects are less important those days, so I see no issue with doing that. I've created an issue to track it (#8).

[vpetrusevici]

Would be good to add a constructor with no parameters for PushMessage, because with current implementation is impossible to deserailise object of this class from json without creating new class and mapping properties

[tpeczek]

@vpetrusevici I will consider that. It opens some error scenarios but maybe it's worth it.

[rouen-sk]

Hey, nice library. However, you should probably add PushServiceClient constructor accepting IHttpClientFactory (instead of HttpClient) and use CreateClient internally to support long-running scenarios correctly.

[tpeczek]

Hi @rouen-sk. Thank you for the feedback. In my mind PushServiceClient is somethign to be used in various scenarios (think of if like of Refit for example), and accepting HttpClient gives the most flexibility. Scenarios like integration with HttpClientFactory, in my opinion, should be done from outside. That said I'm happy to conider some generic purpose extensions to HttpClientFactory which would make this easier (I have some for ASP.NET Core, but from time perspective they seem too opinionated).

[shareonline]

I just found this as I am investigating why I can't seem to get the Webpush. Net nuget package to work correctly on android.
I have everything set up and my chromium edge win11 pc gets all notifications correctly, even when deployed to Azure. But I simply can't get android to work with it, and others like progressier for instance work fine.

I was wondering if this library works without issues on newest versions of android/Chrome etc?

And thanks for your work by the way! If this works as expected a beer or alike will certainly be thrown at you :)

Is this updated to use newest versions available for dependencies?

[tpeczek]

I just found this as I am investigating why I can't seem to get the Webpush. Net nuget package to work correctly on android. I have everything set up and my chromium edge win11 pc gets all notifications correctly, even when deployed to Azure. But I simply can't get android to work with it, and others like progressier for instance work fine.

I was wondering if this library works without issues on newest versions of android/Chrome etc?

And thanks for your work by the way! If this works as expected a beer or alike will certainly be thrown at you :)

Is this updated to use newest versions available for dependencies?

Hi @shareonline,

The general answer is yes, this library supports Web Push in all OS/browser scenarios where the browser supports it. This includes Android/Chrome.

One Chrome specific aspect that has surfaced with one of latest versions, is that Chrome has started to complain about certain VAPID keys, you can read more in this issue: #29. If that is your case, than you need to play a little bit with keys provided in configuration. If you are picking up any other error, please share it and I'll take a look as soon as I will be able to carve some time.