Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transferring to JuliaMusic #1

Open
aminya opened this issue Dec 25, 2019 · 3 comments
Open

Transferring to JuliaMusic #1

aminya opened this issue Dec 25, 2019 · 3 comments

Comments

@aminya
Copy link

aminya commented Dec 25, 2019

It would be good to transfer this repository to JuliaMusic. I was going to make a package that does this. I am happy that it is already created 🎸

Here is the issue I had in MusicXML
JuliaMusic/MusicXML.jl#4

I developed AcuteML.jl.

Then I used it inside MusicXML.jl.
I planned to use AcuteML and plot fretboards using Html or PyCall.

Here is the issue in MusicVisualizations.jl
JuliaMusic/MusicVisualizations.jl#1

@tpapp
Copy link
Owner

tpapp commented Dec 25, 2019

I am open to the idea, let's revisit this issue when I have a working prototype.

@aminya
Copy link
Author

aminya commented Dec 28, 2019

Sure. But for example, the code in notes.jl can be moved either to Midi.jl or MusicXML.jl.
We already have
a Note type
https://github.com/JuliaMusic/MIDI.jl/blob/cf99e27a519ccbbf729c6ca078a8fed94a6137e5/src/note.jl#L7
and a NoteX type
https://github.com/JuliaMusic/MusicXML.jl/blob/0356abcf3bc18efc534506844cb3c5843d079b5d/src/MusicXML.jl#L462

For Fretboards.jl I think MusicXml is a better place.
I planned to add Guitar tab support.
https://www.musicxml.com/tutorial/tablature/fret-and-string/

@tpapp
Copy link
Owner

tpapp commented Aug 18, 2021

I recently refactored and simplified the code, realizing that what I called a note is better described as a pitch. Both the Note and NoteX types mentioned above do much more, so I am not sure what the benefit of using them would be for this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants