-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loading a group makes a ton of API calls... #85
Comments
@ajefts is there any group on dev server that I can use to test this issue? |
This is the biggest group in dev, but you should be able to see the
multiple calls with it:
https://admin.topcoder-dev.com/#/index/groupmembers/20000000/list
…On Wed, Aug 23, 2017 at 1:01 PM, huangqun ***@***.***> wrote:
@ajefts <https://github.com/ajefts> is there any group on dev server that
I can use to test this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#85 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADorrkaBtEX_ADqhFsyKusmto2RTAGuzks5sbFrpgaJpZM4O9eJI>
.
|
@ajefts to fix this issue, I think we need to add new endpoints to get groups / users from the server in batch, see attached api definition: After this is done, I guess we need to update the admin-app to use the new endpoints to avoid so many api calls. Let me know if we should go ahead with these. |
could we just use some kind of paging? Load 20 users per page and use offset/limit on the api calls? |
@ajefts that doesn't look like a problem with paging, take the example you shared: https://admin.topcoder-dev.com/#/index/groupmembers/20000000/list There are less than 20 users in the group, but it's still making a ton of calls. |
@cwdcwd @mtwomey Looping you in to this one for an API decision. What's the right way to do this? The admin page is trying to list all users in the group, so it calls https://api.topcoder-dev.com/v3/groups/20000000/members to get the list...but that only has IDs...so then it turns around and calls the user api for each user to add things like handle.... yuck.... |
No description provided.
The text was updated successfully, but these errors were encountered: