Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loading a group makes a ton of API calls... #85

Open
ajefts opened this issue Aug 21, 2017 · 6 comments
Open

loading a group makes a ton of API calls... #85

ajefts opened this issue Aug 21, 2017 · 6 comments
Assignees

Comments

@ajefts
Copy link
Member

ajefts commented Aug 21, 2017

No description provided.

@huangqun
Copy link
Collaborator

@ajefts is there any group on dev server that I can use to test this issue?

@ajefts
Copy link
Member Author

ajefts commented Aug 23, 2017 via email

@huangqun
Copy link
Collaborator

@ajefts to fix this issue, I think we need to add new endpoints to get groups / users from the server in batch, see attached api definition:
swagger.yaml.zip

After this is done, I guess we need to update the admin-app to use the new endpoints to avoid so many api calls.

Let me know if we should go ahead with these.

@ajefts
Copy link
Member Author

ajefts commented Feb 27, 2018

could we just use some kind of paging? Load 20 users per page and use offset/limit on the api calls?

@huangqun
Copy link
Collaborator

@ajefts that doesn't look like a problem with paging, take the example you shared: https://admin.topcoder-dev.com/#/index/groupmembers/20000000/list

There are less than 20 users in the group, but it's still making a ton of calls.

@ajefts
Copy link
Member Author

ajefts commented Mar 1, 2018

@cwdcwd @mtwomey Looping you in to this one for an API decision. What's the right way to do this?

The admin page is trying to list all users in the group, so it calls https://api.topcoder-dev.com/v3/groups/20000000/members to get the list...but that only has IDs...so then it turns around and calls the user api for each user to add things like handle.... yuck....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants