-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI elements are not scaled properly #343
Comments
Did you generate these by some machine learning solution? If so, can it handle the transparencies? Also we could generate the test data with the same lib then :) |
I tested Gigapixel. With transparency you get color fringes. |
I used https://github.com/xinntao/ESRGAN awhile back. Otherwise I got very nice results, but it didn't support transparencies. Got amazing detail to Reaper (https://cdn.knightlab.com/libs/juxtapose/latest/embed/index.html?uid=db515096-1e79-11e9-9dba-0edaf8f81e27). Normal maps... Yeah you need to be up close and personal with them. Also we are only currently using only ambient light. I guess that contributes to the fact that everything looks a bit flat. We have an experimental branch (https://github.com/tonihele/OpenKeeper/tree/experimental-light) with real lights that was used by a artist for creating custom graphics with normal maps. The branch hasn't been updated in awhile, but it still of course works to see the graphics. |
Most don't. You end up having to upscale the alpha separately and then recombine.
Btw there is no launcher script for the model viewer.
Yes I noticed that as well. Of course normal maps don't make a difference without at least diffuse lighting.
I rebased it but too much has changed in the code for it to just work: https://github.com/Trass3r/OpenKeeper/tree/experimental-light |
Yeah, I think the code was before our huge restructure. I can try to bring it to life in few days. There wasn't huge changes that I made back then. |
Yeah it should definitely improve the visuals. |
When using higher-resolution images:
The text was updated successfully, but these errors were encountered: