Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve metrics collection and reporting #7

Open
skywhale opened this issue Feb 19, 2021 · 3 comments
Open

Improve metrics collection and reporting #7

skywhale opened this issue Feb 19, 2021 · 3 comments

Comments

@skywhale
Copy link
Member

No description provided.

@strohel
Copy link
Member

strohel commented Feb 21, 2021

Would this mean providing something more than just NoopMetricsHandler, or perhaps even more thorough changes?

I'm on the fence, it could be the case that "easy" use-cases don't care about metrics that much, and "advanced" use-cases may want to use own metrics handler anyway.

Perhaps the goal could be that the "core" is lean, but still able to collect metrics user-supplied code (or some actor-metrics future crate)? Somewhat related to #27 may or may not help with this.

Probably not necessarily Before Release thing, current metrics collection seems to be okayish.

@bschwind
Copy link
Member

One crate we were eyeing is metrics, which is a metrics facade similar to log. In general I would like to remove the generic bound on MetricsHandler since it complicates the code a bit.

@mcginty
Copy link
Collaborator

mcginty commented Feb 22, 2021

Yeah, maybe having an optional metrics feature would be the right way to do this (and when enabled, reports metrics using that metrics crate).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants