Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

game security #2

Open
LokartBC opened this issue Feb 19, 2022 · 1 comment
Open

game security #2

LokartBC opened this issue Feb 19, 2022 · 1 comment

Comments

@LokartBC
Copy link

Hi, I found 2 security issues that need improvment:

  • adding private salt input to board hashing to prevent attacker from computing the hash
  • ship positions must be verified to be sure boats don't overlap which would be cheating
@lhoste-bell
Copy link

I found an additional issue: currently the positions of the ships can be modified during gameplay by the prover.
It is required to enforce x/y/o coordinates to 2^4 bits such that the prover cannot manipulate input data which still matches the hash value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants