Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Basic Authentication Support for OpenTelemetryCollector Configuration #2294

Open
bunkrur opened this issue May 11, 2023 · 3 comments
Open
Assignees
Labels
feature All issues that are new features help-wanted All issues where people can contribute to the project integration:opentelemetry

Comments

@bunkrur
Copy link

bunkrur commented May 11, 2023

Proposal

Issue Description
I'd like to be able to use authentication against an OpenTelemetry collector endpoint within the Promiter configuration. Currently, I am having to forward to proxy collector that is handling the authentication and then forwarding to yet another collector (observability for an organization of organizations). It would be amazing to be able to egress to a collector with authentication.

Proposed Solution
Add the ability to specify header authentication

openTelemetryCollector:
  enabled: true
  collectorUri: "http://{{ .Values.runtime.metricSinks.openTelemetryCollector.dns }}:4317"
  headers:
    Authorization:. {{ Values.runtime.metricSinks.openTelemetryCollector.AuthorizationValue}}

Component

Resource Discovery, Scraper

Contact Details

No response

@tomkerkhove
Copy link
Owner

Interesting idea, are you willing to contribute this?

@tomkerkhove tomkerkhove added help-wanted All issues where people can contribute to the project feature All issues that are new features integration:opentelemetry and removed feature-request New feature requests labels May 11, 2023
@tomkerkhove tomkerkhove moved this from Proposed to Todo in Promitor Roadmap May 11, 2023
@bunkrur
Copy link
Author

bunkrur commented May 11, 2023

Going to say yes. Can we sync over a call about how you might want it implemented?

@tomkerkhove
Copy link
Owner

It depends what you want to discuss - I prefer to see what the current documentation lacks that avoids you from finding what you need so that I can improve it for other maintainers (don't get me wrong)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature All issues that are new features help-wanted All issues where people can contribute to the project integration:opentelemetry
Projects
Status: Todo
Development

No branches or pull requests

2 participants