Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

"ansible.builtin.assert.that" should be highlighted just as "when" #31

Open
yajo opened this issue Oct 27, 2021 · 1 comment
Open

"ansible.builtin.assert.that" should be highlighted just as "when" #31

yajo opened this issue Oct 27, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@yajo
Copy link

yajo commented Oct 27, 2021

Problem

no problem, just an ehnancement

Solution

When using the ansible.builtin.assert module, highlight the that argument just like a when.

Alternatives

Live without it.

Additional context

Quoting from https://docs.ansible.com/ansible/latest/collections/ansible/builtin/assert_module.html:

that: A list of string expressions of the same form that can be passed to the 'when' statement.

@yajo yajo added the enhancement New feature or request label Oct 27, 2021
@tomaciazek
Copy link
Owner

Yes, assert...that is quite a special condition. It's going to be tricky to implement. Essentially, it shouldn't be done in TextMate grammar as that would make it really complex and verbose for just this one case. But in the same time, implementing that in the dynamic syntax-highlighting in language server, might require implementing jinja syntax highlighting there too... which I'm not so enthusiastic about...

I'll investigate the options

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants