From bd5255523f42910004e46f4fe278c19819b62514 Mon Sep 17 00:00:00 2001 From: Tom Howlett Date: Wed, 15 Mar 2023 16:44:37 +0100 Subject: [PATCH 01/12] fixed some dubious formatting --- DotNet5WebApi/WeatherForecast.cs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/DotNet5WebApi/WeatherForecast.cs b/DotNet5WebApi/WeatherForecast.cs index 3eacf46..44799c4 100644 --- a/DotNet5WebApi/WeatherForecast.cs +++ b/DotNet5WebApi/WeatherForecast.cs @@ -15,7 +15,6 @@ public bool IsFreezing() return TemperatureC <= 0; } - public string Summary { - get; set; } + public string Summary { get; set; } } } From e4e8a9bdc2892b67dba95d9a7759a4ffcaa5178a Mon Sep 17 00:00:00 2001 From: Tom Howlett Date: Thu, 16 Mar 2023 10:10:39 +0100 Subject: [PATCH 02/12] small change to update pr --- DotNet5WebApi/WeatherForecast.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DotNet5WebApi/WeatherForecast.cs b/DotNet5WebApi/WeatherForecast.cs index 44799c4..82f7847 100644 --- a/DotNet5WebApi/WeatherForecast.cs +++ b/DotNet5WebApi/WeatherForecast.cs @@ -15,6 +15,6 @@ public bool IsFreezing() return TemperatureC <= 0; } - public string Summary { get; set; } + public string Summary { get; set; } } } From 3b5ee64b42f6b92d66c103bce17d298ee752fa1a Mon Sep 17 00:00:00 2001 From: Tom Howlett Date: Thu, 16 Mar 2023 10:20:42 +0100 Subject: [PATCH 03/12] updated yml to test parameters --- .github/workflows/dotnet.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index 1a29270..c22c434 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -48,7 +48,7 @@ jobs: shell: powershell run: | dotnet restore - .\.sonar\scanner\dotnet-sonarscanner begin /k:"tom-howlett-sonarsource_DotNet5WebApi" /o:"tom-howlett-sonarsource" /d:sonar.login="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" + .\.sonar\scanner\dotnet-sonarscanner begin /k:"tom-howlett-sonarsource_DotNet5WebApi" /o:"tom-howlett-sonarsource" /d:sonar.login="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.pullrequest.base=master /d:sonar.pullrequest.branch=inctest2 /d:sonar.pullrequest.key=42 /d:sonar.verbose=true dotnet build --no-restore .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.login="${{ secrets.SONAR_TOKEN }}" From 1d2b4d41bed6044d8238b1f280dd1d802591e5dd Mon Sep 17 00:00:00 2001 From: Tom Howlett Date: Thu, 16 Mar 2023 10:25:20 +0100 Subject: [PATCH 04/12] format change to trigger pr update? --- DotNet5WebApi/WeatherForecast.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DotNet5WebApi/WeatherForecast.cs b/DotNet5WebApi/WeatherForecast.cs index 82f7847..44799c4 100644 --- a/DotNet5WebApi/WeatherForecast.cs +++ b/DotNet5WebApi/WeatherForecast.cs @@ -15,6 +15,6 @@ public bool IsFreezing() return TemperatureC <= 0; } - public string Summary { get; set; } + public string Summary { get; set; } } } From 786216127deb40723f7531eb17ea0eba7a776550 Mon Sep 17 00:00:00 2001 From: Tom Howlett Date: Thu, 16 Mar 2023 10:33:24 +0100 Subject: [PATCH 05/12] corrected pr id for testing --- .github/workflows/dotnet.yml | 2 +- DotNet5WebApi/WeatherForecast.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index c22c434..5193c27 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -48,7 +48,7 @@ jobs: shell: powershell run: | dotnet restore - .\.sonar\scanner\dotnet-sonarscanner begin /k:"tom-howlett-sonarsource_DotNet5WebApi" /o:"tom-howlett-sonarsource" /d:sonar.login="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.pullrequest.base=master /d:sonar.pullrequest.branch=inctest2 /d:sonar.pullrequest.key=42 /d:sonar.verbose=true + .\.sonar\scanner\dotnet-sonarscanner begin /k:"tom-howlett-sonarsource_DotNet5WebApi" /o:"tom-howlett-sonarsource" /d:sonar.login="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.pullrequest.base=master /d:sonar.pullrequest.branch=inctest2 /d:sonar.pullrequest.key=3 /d:sonar.verbose=true dotnet build --no-restore .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.login="${{ secrets.SONAR_TOKEN }}" diff --git a/DotNet5WebApi/WeatherForecast.cs b/DotNet5WebApi/WeatherForecast.cs index 44799c4..82f7847 100644 --- a/DotNet5WebApi/WeatherForecast.cs +++ b/DotNet5WebApi/WeatherForecast.cs @@ -15,6 +15,6 @@ public bool IsFreezing() return TemperatureC <= 0; } - public string Summary { get; set; } + public string Summary { get; set; } } } From e553ce39d61a1e8911a7837a0405364d94300ae5 Mon Sep 17 00:00:00 2001 From: Tom Howlett Date: Thu, 16 Mar 2023 10:54:01 +0100 Subject: [PATCH 06/12] updated gh action to only specify base branch --- .github/workflows/dotnet.yml | 2 +- DotNet5WebApi/WeatherForecast.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index 5193c27..ced1ca9 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -48,7 +48,7 @@ jobs: shell: powershell run: | dotnet restore - .\.sonar\scanner\dotnet-sonarscanner begin /k:"tom-howlett-sonarsource_DotNet5WebApi" /o:"tom-howlett-sonarsource" /d:sonar.login="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.pullrequest.base=master /d:sonar.pullrequest.branch=inctest2 /d:sonar.pullrequest.key=3 /d:sonar.verbose=true + .\.sonar\scanner\dotnet-sonarscanner begin /k:"tom-howlett-sonarsource_DotNet5WebApi" /o:"tom-howlett-sonarsource" /d:sonar.login="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.pullrequest.base=master /d:sonar.verbose=true dotnet build --no-restore .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.login="${{ secrets.SONAR_TOKEN }}" diff --git a/DotNet5WebApi/WeatherForecast.cs b/DotNet5WebApi/WeatherForecast.cs index 82f7847..44799c4 100644 --- a/DotNet5WebApi/WeatherForecast.cs +++ b/DotNet5WebApi/WeatherForecast.cs @@ -15,6 +15,6 @@ public bool IsFreezing() return TemperatureC <= 0; } - public string Summary { get; set; } + public string Summary { get; set; } } } From d1e25c593e6f21462e78e86d7055fdfeee83c870 Mon Sep 17 00:00:00 2001 From: Tom Howlett Date: Fri, 17 Mar 2023 13:08:06 +0100 Subject: [PATCH 07/12] added verbose logging --- DotNet5WebApi/WeatherForecast.cs | 2 +- azure-pipelines.yml | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/DotNet5WebApi/WeatherForecast.cs b/DotNet5WebApi/WeatherForecast.cs index 44799c4..82f7847 100644 --- a/DotNet5WebApi/WeatherForecast.cs +++ b/DotNet5WebApi/WeatherForecast.cs @@ -15,6 +15,6 @@ public bool IsFreezing() return TemperatureC <= 0; } - public string Summary { get; set; } + public string Summary { get; set; } } } diff --git a/azure-pipelines.yml b/azure-pipelines.yml index a158820..fd91db6 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -28,6 +28,8 @@ steps: scannerMode: 'MSBuild' projectKey: 'christophehavard_DotNet5WebApi_SC' projectName: 'DotNet5WebApi_SC' + extraProperties: | + sonar.verbose=true - task: VSBuild@1 inputs: solution: '$(solution)' From 16ebb853ae44e1d2a67c0e6c63bb731c34bcba66 Mon Sep 17 00:00:00 2001 From: Tom Howlett <83457846+tom-howlett-sonarsource@users.noreply.github.com> Date: Wed, 12 Apr 2023 08:49:59 +0100 Subject: [PATCH 08/12] removed master branch as will now get picked from CI --- .github/workflows/dotnet.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index ced1ca9..48f80cc 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -48,7 +48,7 @@ jobs: shell: powershell run: | dotnet restore - .\.sonar\scanner\dotnet-sonarscanner begin /k:"tom-howlett-sonarsource_DotNet5WebApi" /o:"tom-howlett-sonarsource" /d:sonar.login="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.pullrequest.base=master /d:sonar.verbose=true + .\.sonar\scanner\dotnet-sonarscanner begin /k:"tom-howlett-sonarsource_DotNet5WebApi" /o:"tom-howlett-sonarsource" /d:sonar.login="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.verbose=true dotnet build --no-restore .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.login="${{ secrets.SONAR_TOKEN }}" From 9d3b7e4fcbff734f3f8354f4e846533497f799d2 Mon Sep 17 00:00:00 2001 From: Tom Howlett <83457846+tom-howlett-sonarsource@users.noreply.github.com> Date: Wed, 12 Apr 2023 08:58:30 +0100 Subject: [PATCH 09/12] Tweak to trigger build and cache --- DotNet5WebApi/WeatherForecast.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DotNet5WebApi/WeatherForecast.cs b/DotNet5WebApi/WeatherForecast.cs index 82f7847..44799c4 100644 --- a/DotNet5WebApi/WeatherForecast.cs +++ b/DotNet5WebApi/WeatherForecast.cs @@ -15,6 +15,6 @@ public bool IsFreezing() return TemperatureC <= 0; } - public string Summary { get; set; } + public string Summary { get; set; } } } From b3a999e45451f100d1f730795be2d8af8ebda29c Mon Sep 17 00:00:00 2001 From: Tom Howlett <83457846+tom-howlett-sonarsource@users.noreply.github.com> Date: Wed, 12 Apr 2023 13:46:14 +0100 Subject: [PATCH 10/12] update to trigger incremental build --- DotNet5WebApi/WeatherForecast.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DotNet5WebApi/WeatherForecast.cs b/DotNet5WebApi/WeatherForecast.cs index 44799c4..82f7847 100644 --- a/DotNet5WebApi/WeatherForecast.cs +++ b/DotNet5WebApi/WeatherForecast.cs @@ -15,6 +15,6 @@ public bool IsFreezing() return TemperatureC <= 0; } - public string Summary { get; set; } + public string Summary { get; set; } } } From 2fdc97cbc5f2887fe1094d96055334831623e5c4 Mon Sep 17 00:00:00 2001 From: Tom Howlett <83457846+tom-howlett-sonarsource@users.noreply.github.com> Date: Wed, 12 Apr 2023 14:17:48 +0100 Subject: [PATCH 11/12] Trigger PR Build --- DotNet5WebApi/WeatherForecast.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DotNet5WebApi/WeatherForecast.cs b/DotNet5WebApi/WeatherForecast.cs index 82f7847..44799c4 100644 --- a/DotNet5WebApi/WeatherForecast.cs +++ b/DotNet5WebApi/WeatherForecast.cs @@ -15,6 +15,6 @@ public bool IsFreezing() return TemperatureC <= 0; } - public string Summary { get; set; } + public string Summary { get; set; } } } From 13a462a4b8960dde934fccc49b841dbe78518d79 Mon Sep 17 00:00:00 2001 From: Tom Howlett Date: Fri, 14 Apr 2023 17:15:45 +0100 Subject: [PATCH 12/12] added an unused variable --- DotNet5WebApi/WeatherForecast.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/DotNet5WebApi/WeatherForecast.cs b/DotNet5WebApi/WeatherForecast.cs index 82f7847..224208f 100644 --- a/DotNet5WebApi/WeatherForecast.cs +++ b/DotNet5WebApi/WeatherForecast.cs @@ -12,6 +12,7 @@ public class WeatherForecast public bool IsFreezing() { + int notused = 1; return TemperatureC <= 0; }