Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority B default color is not bold #339

Open
YodaEmbedding opened this issue Mar 31, 2021 · 2 comments
Open

Priority B default color is not bold #339

YodaEmbedding opened this issue Mar 31, 2021 · 2 comments

Comments

@YodaEmbedding
Copy link

YodaEmbedding commented Mar 31, 2021

The default todo.cfg contains:

export GREEN='\\033[0;32m'
export PRI_B=$GREEN

However, for consistency with the other priorities (which are bold), it should actually be:

export GREEN_BOLD='\\033[1;32m'
export PRI_B=$GREEN_BOLD
@inkarkat
Copy link
Member

inkarkat commented Apr 1, 2021

All "light" default colors (but oddly DARK_GREY, not LIGHT_GREY) are bold. I would come to the conclusion that these colors were not clearly distinguishable to the original author (based on their color scheme and terminal background), so they were made bold. Therefore, I would not deduce that green should be bold as well.

The colors and priority highlightings are easily customized in the config file; the one that's shipped is just a template and documents the built-in defaults. I personally would argue that changing the default would affect more (existing) users negatively (in that they have to recognize the change and adapt) than what the consistency would bring for new users.

@xsrvmy
Copy link

xsrvmy commented Jan 8, 2022

If the desire is to change the color, rather than to use bold, it may be better to use escape codes 90-97 (which selects bright colors without causing them to be bold) instead of 30-31 bold actually. Some terminals don't even use bright for bold by default anymore.

BTW DARK_GREY is bold because it's actually bright black, and LIGHT_GREY is dark white.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants