Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch protection rules #69

Closed
gyehuda opened this issue Jun 5, 2020 · 6 comments
Closed

branch protection rules #69

gyehuda opened this issue Jun 5, 2020 · 6 comments

Comments

@gyehuda
Copy link
Member

gyehuda commented Jun 5, 2020

Should we set up branch protection on some of our repos to ensure that more than one pair of eyes is involved in a change to content? If so, which? If not, at least we raised the conversation and decided.

@vmbrasseur
Copy link
Contributor

I'm on the fence.

On the one hand, we're not really target material. This would be premature optimisation and add overhead.

On the other hand…it's not like it's a lot of overhead and I don't anticipate it'd be that onerous or otherwise slow us down.

@willnorris
Copy link
Member

+1 to @vmbrasseur's comment. I'd suggest we try it and see if it really turns out to be too much overhead?

@justaugustus
Copy link
Member

Sub-item of #106.

@anajsana
Copy link
Member

@justaugustus can we close this? I think it's done now that the SC has admin access to the whole GH org, so more than one person have the right permissions to change content

@jordanrule
Copy link

I'm sort of a newcomer here so don't take my perspective too seriously, but I for one am still a bit concerned about overhead on the rules.

@anajsana
Copy link
Member

anajsana commented Feb 2, 2024

branch protection rules are enabled in the most active repos, including:

ospology
todogorup.org
ospo-career-path

Since this is a very old issue, I will close this and suggest opening a new issue if needed to work on defining a concrete branch protection rule (e.g approval from a second reviewer required) in a targeted repo (e.g ospolandscape) in the future 👍

@anajsana anajsana closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants