You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I designed libtock_unittest, I intended for users of libtock-rs to be able to build their own fake::SyscallDriver implementations. Such implementations would be contained in crates with a dependency on libtock_unittest, and will therefore be unable to depend on pub(crate) items in libtock_unittest.
We currently have these drivers in libtock_unittest, which allows us to accidentally depend on pub(crate) items. I think we should move the fake::SyscallDriver implementations into their own crate, so our build system verifies that non-pub dependencies haven't cropped up.
I suggest the name libtock_fake_drivers for the new crate.
Do any of you have an opinion on this topic?
The text was updated successfully, but these errors were encountered:
When I designed
libtock_unittest
, I intended for users oflibtock-rs
to be able to build their ownfake::SyscallDriver
implementations. Such implementations would be contained in crates with a dependency onlibtock_unittest
, and will therefore be unable to depend onpub(crate)
items inlibtock_unittest
.We currently have these drivers in
libtock_unittest
, which allows us to accidentally depend onpub(crate)
items. I think we should move thefake::SyscallDriver
implementations into their own crate, so our build system verifies that non-pub
dependencies haven't cropped up.I suggest the name
libtock_fake_drivers
for the new crate.Do any of you have an opinion on this topic?
The text was updated successfully, but these errors were encountered: