Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split fake::SyscallDriver implementations out of libtock_unittest #416

Open
jrvanwhy opened this issue Jun 27, 2022 · 1 comment
Open

Split fake::SyscallDriver implementations out of libtock_unittest #416

jrvanwhy opened this issue Jun 27, 2022 · 1 comment

Comments

@jrvanwhy
Copy link
Collaborator

When I designed libtock_unittest, I intended for users of libtock-rs to be able to build their own fake::SyscallDriver implementations. Such implementations would be contained in crates with a dependency on libtock_unittest, and will therefore be unable to depend on pub(crate) items in libtock_unittest.

We currently have these drivers in libtock_unittest, which allows us to accidentally depend on pub(crate) items. I think we should move the fake::SyscallDriver implementations into their own crate, so our build system verifies that non-pub dependencies haven't cropped up.

I suggest the name libtock_fake_drivers for the new crate.

Do any of you have an opinion on this topic?

@hudson-ayers
Copy link
Contributor

That sounds like a reasonable change to me! +1 to the name you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants