Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to make this work with hoisted lerna projects? #11

Open
danielantelo opened this issue Jul 9, 2020 · 7 comments
Open

Any plans to make this work with hoisted lerna projects? #11

danielantelo opened this issue Jul 9, 2020 · 7 comments

Comments

@danielantelo
Copy link

danielantelo commented Jul 9, 2020

Currently struggling to run an auto npm audit fix on our lerna project which is configured to hoist. Have tried npx lerna-audit but it seems to look for lock files in each package instead of following the lerna hoist conf route.

@svettwer
Copy link
Collaborator

Hi 👋!

Thx for your input. Currently hoisted projects are not supported but would be a cool improvement. AFAIK there are no plans to add support for hoisted lerna projects in the near future, so a PR would be highly appreciated.

BR
Sven

@IgnorantSapient
Copy link

IgnorantSapient commented Apr 19, 2021

Hey @svettwer is this project still being actively maintained, I'd love to coordinate with you and make lerna-audit and make it work with hosted projects.

I am more than happy to send you PR.

@svettwer
Copy link
Collaborator

Hey @123aswin123! 👋

@tnobody and I are sharing the maintenance of this project. PRs are always welcome and will be reviewed, merged and released at best effort. If you'd like to propose a new feature, I'll be happy to review and help with questions. 😁👍

@IgnorantSapient
Copy link

IgnorantSapient commented Apr 19, 2021

Okay, so I'd like to send a PR for lerna-audit to work with hoisted lerna projects, do I raise a new issue for tracking this? or can we discuss it in this issue itself?

Thanks for your help @svettwer

@svettwer
Copy link
Collaborator

As this issue is about hoisted project support, I'd just reopen it, so that we can discuss here. 👍

@svettwer svettwer reopened this Apr 20, 2021
@utsavkapoor
Copy link

Any updates on this enhancement. I wanted to use lerna-audit package for my hoisted repo

@svettwer
Copy link
Collaborator

Nope, no update currently. But we're always happy to receive PRs. 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants