Error: Information about the C++ toolchain API is not accessible anymore through ctx.fragments.cpp

[plule]

Hello and first, thanks for making this!

It seems that a bazel change broke Lavender. When trying to convert a project, I get:

Information about the C++ toolchain API is not accessible anymore through ctx.fragments.cpp (see --incompatible_disable_legacy_cpp_toolchain_skylark_api on http://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-configuration-api for migration notes). Use CcToolchainInfo instead.

The link provides instructions for migration, but I just started learning Bazel so I did not manage to fix it myself. Removing the + ctx.fragments.cpp.compiler_options([]) + ctx.fragments.cpp.cxx_options([]) parts from msbuild.bzl allows the script to complete.

[tmandry]

Hey, thanks for your report! I'm not actively maintaining this anymore, unfortunately (and don't have a codebase to test it with), but willing to help guide you through fixing it.

The before/after example from the documentation you linked is more or less what needs to be done. You need to add a load statement to the top of the file:

load("@bazel_tools//tools/cpp:toolchain_utils.bzl", "find_cpp_toolchain")

Then, at the top of this function:

lavender/bazel/bazel-msbuild/msbuild.bzl

Lines 1 to 10 in d867ab5

	def _get_project_info(target, ctx):
	cc = getattr(target, 'cc', None)
	if cc:
	cc_info = struct(
	include_dirs = cc.include_directories,
	system_include_dirs = cc.system_include_directories,
	quote_include_dirs = cc.quote_include_directories,
	compile_flags = cc.compile_flags + ctx.fragments.cpp.compiler_options([]) + ctx.fragments.cpp.cxx_options([]),
	defines = cc.defines,
	)

add the line cc_toolchain = find_cpp_toolchain(ctx), and you should be able to replace those expressions you removed with their counterparts, listed in the table on the doc page you linked to. Looks like you can remove the unused [] arguments in each of them.

[tmandry]

Let me know if you have any issues. If you get it working, please submit a PR and I'll get it merged. Thanks!

[plule]

Thanks for the guidance, I'll take a look at it!

[lummax]

lummax@623e18c was my attempt at this. Inspired by https://github.com/grailbio/bazel-compilation-database

Edit: And xforce@01609c4 is another one.