Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notary-server: fix paths #687

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

notary-server: fix paths #687

wants to merge 1 commit into from

Conversation

maceip
Copy link
Collaborator

@maceip maceip commented Jan 22, 2025

this pr modifies the info and health endpoints to use relative paths which are compatible with the standalone notary-server and hosted versions behind reverse proxies

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.95%. Comparing base (65299d7) to head (99e1abb).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #687      +/-   ##
==========================================
+ Coverage   55.76%   55.95%   +0.18%     
==========================================
  Files         189      189              
  Lines       20886    20751     -135     
==========================================
- Hits        11648    11611      -37     
+ Misses       9238     9140      -98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@heeckhau heeckhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nightly looks very different from alpha.7

Remote attestation links to info

image

image

@maceip
Copy link
Collaborator Author

maceip commented Feb 3, 2025

Nightly looks very different from alpha.7

Not sure if your page was cached but when i load /nightly it looks like the following for me =>

Screenshot_20250203-161709

@heeckhau
Copy link
Member

heeckhau commented Feb 4, 2025

I was not talking about the content of the info json. I was talking about the html content:

Screenshot 2025-02-04 at 10 20 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants