Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup call to Base.parse_cache_header for v1.11 #18

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

fatteneder
Copy link
Contributor

Starting with Julia v1.11 we need to hand the file path to Base.parse_cache_header in order to get sensible debug messages. (xref JuliaLang/julia#49866)

Q: Is it ok to bump the compat entry here or should this be done together with a version bump?

@fatteneder fatteneder changed the title fixup parse_cache_header for v1.11 fixup call to Base.parse_cache_header for v1.11 Oct 14, 2023
@vchuravy
Copy link
Collaborator

Normally we do a version check. So as soon as your code landed on master we can do @static if VERSION

@fatteneder
Copy link
Contributor Author

Ok. Fixed that. But will need to update version number once the other PR is merged.

@mkitti
Copy link

mkitti commented Nov 21, 2023

Looks good to me. I was just looking for this in #21. @vchuravy , merge?

@timholy timholy merged commit fc71600 into timholy:main Nov 21, 2023
@timholy
Copy link
Owner

timholy commented Nov 21, 2023

Thanks!

@fatteneder fatteneder deleted the fa/prepare-v1.11 branch November 29, 2023 22:38
@fatteneder fatteneder mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants