-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing #38
Comments
Hey, that's a great question. |
Ah I see, it would make sense to not have tests if it is a proof of concept. My point, directly about adding tests
I have not used Playwright before, but it sounds nice. I will try to get some tests going for that when I take another go at the validator + value setting. Thanks for clarifying. My opinion on adoption as a potential adopter, since you mention it
Makes sense. Personally, I think a lack of tests may be keeping back some potential adopters. I was going to make the case to my work's team to pull this library into a project, but no tests among other other things made me cautious. It makes sense now that you clarify the intent and scale of adoption. Thank you for clarifying, and what is already here. It makes sense, you do a lot of great stuff and this is just one project. |
Yea, it's a "chicken and egg problem" when it comes to tests <> early adaptors 😅 If someone wants to put time into it, I will definitely take the time to brainstorm/review changes. |
In my attempts with the form group setting issue #26, I have found myself wanting tests. So I made some on this branch of mine that was just focused on getting tests started: main...michael-small:ng-signal-forms:add-testing-library-tests
My question(s) in regards to tests
@testing-library/angular
, appropriate for this project?If you think it is reasonable to use
@testing-library/angular
for the project, I would like to add a lot more tests, at least ones to bolster the form group setting issue. And with the ones I made on that branch, I imagine they could be better (I see you have articles on using Angular Testing Library that I haven't read yet), but I don't want to polish them or write more if you think they aren't the most appropriate for this project.If you think it is worth it to have tests but a different type of tests, I would like to learn how to make those. But if you are fine with me using Angular Testing Library in this weird way, then I will probably proceed with writing more.
The text was updated successfully, but these errors were encountered: