Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conflicting exceptions #526

Open
timcassell opened this issue Feb 1, 2025 · 0 comments
Open

Remove conflicting exceptions #526

timcassell opened this issue Feb 1, 2025 · 0 comments
Milestone

Comments

@timcassell
Copy link
Owner

timcassell commented Feb 1, 2025

Some exceptions in the Proto.Promises namespace have the same name as exceptions in the System namespace (example ArgumentNullException). Including both namespaces in a file is common, leading to ambiguities when trying to throw one of these exceptions without using the fully qualified name. This was largely done for simple double-click exception messages in Unity's console (the StackTrace property is overridden to ignore internal stack frames), and so that users could still catch the system exception type and see the same type name in its ToString.

We are already using .Net 6's [StackTraceHidden], and Unity is working on adding latest .Net support, so I think the convenience of the console double-click will soon be moot. I also feel it is outweighed by the inconvenience of the ambiguities, and older Unity console can just click the line of the stack frame in the extended message, instead of double-clicking the short message.

@timcassell timcassell added this to the v4.0.0 milestone Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant