Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rider/jetbrains IDEs trigger tilt to sync a whole folder instead of only the file that changed #6485

Open
hahn-kev opened this issue Jan 14, 2025 · 1 comment · May be fixed by #6488
Open

rider/jetbrains IDEs trigger tilt to sync a whole folder instead of only the file that changed #6485

hahn-kev opened this issue Jan 14, 2025 · 1 comment · May be fixed by #6488
Labels
bug Something isn't working

Comments

@hahn-kev
Copy link

Expected Behavior

When I save a file in Rider it should trigger tilt to sync that one file

Current Behavior

When I save a file tilt reports this:

Will copy 2 file(s) to container: [ui-55f85ffbf9-jhmzm/ui]
- 'C:\dev\LexBox\frontend\src\lib' --> '/app/src/lib'
- 'C:\dev\LexBox\frontend\src\lib\app.postcss' --> '/app/src/lib/app.postcss'

when I change app.postcss in jetbrains rider, I assume the same thing happens in other editors

Steps to Reproduce

  1. start tilt
  2. with a project open in Rider make a file change and save it
  3. notice that tilt thinks the folder change also

Context

tilt doctor Output

Tilt: v0.33.20, built 2024-09-03
System: windows-amd64
---
Docker
- Host: npipe:////./pipe/dockerDesktopLinuxEngine
- Server Version: 27.4.0
- API Version: 1.47
- Builder: 2
- Compose Version: v2.31.0-desktop.2
---
Kubernetes
- Env: docker-desktop
- Context: docker-desktop
- Cluster Name: docker-desktop
- Namespace: languagedepot
- Container Runtime: docker
- Version: v1.30.2
- Cluster Local Registry: none
---

About Your Use Case

This triggers the build tools inside my container (vite in this case) to rebuild everything inside that folder, rather than just the thing that was changed. You can see our tiltfile here.
@hahn-kev hahn-kev added the bug Something isn't working label Jan 14, 2025
@nicks
Copy link
Member

nicks commented Jan 14, 2025

thanks for the report! i can repro. i think something changed with how windows emits file events

for the record, it doesn't upload the whole dir, just touches the dir entry (though it's still something we should fix)

nicks added a commit that referenced this issue Jan 16, 2025
@nicks
watch: tweak dir change events
33925ac 
fixes #6485

Signed-off-by: Nick Santos <[email protected]>
nicks added a commit that referenced this issue Jan 16, 2025
@nicks
watch: tweak dir change events
545489e 
fixes #6485

Signed-off-by: Nick Santos <[email protected]>
@nicks nicks linked a pull request Jan 16, 2025 that will close this issue
Open
nicks added a commit that referenced this issue Jan 16, 2025
@nicks
watch: tweak dir change events
168a244 
fixes #6485

Signed-off-by: Nick Santos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

watch: tweak dir change events tilt-dev/tilt
2 participants
@nicks @hahn-kev