Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm-sync-lib should provide a synchronous API to validate the content of .pnpm-sync.json #32

Open
dmichon-msft opened this issue May 15, 2024 · 0 comments

Comments

@dmichon-msft
Copy link

For integration with Rush, best practice with .pnpm-sync.json files would be to read them all up front before execution starts, validate that the files have the expected versions, and then error out early.

This helps clean up the logging output by reporting configuration errors with .pnpm-sync at the start of the process, rather than partway through a build. In the current configuration, the logging output can get buried when there are a large number of projects, e.g.

==[ FAILURE: 2 operations ]====================================================

--[ FAILURE: @rushstack/eslint-patch (build) ]--------------[ 14.38 seconds ]--


--[ FAILURE: @rushstack/tree-pattern (build) ]---------------[ 2.98 seconds ]--



Operations failed.

rush build (14.53 seconds)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant