Upkeep 2024-10 #6156
Merged
Upkeep 2024-10 #6156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pkgdown::build_favicons(overwrite = TRUE)`
* replace `expect_error()` by `expect_snapshot(error = TRUE)` * censor machine dependent paths in snapshots * commit snapshots * skip gnarly snapshots
|
The following bullet:
Was only exercised for |
thomasp85
reviewed
Oct 29, 2024
thomasp85
reviewed
Oct 30, 2024
| test_that("accessing an undefined variable results in an error", { | ||
| skip_if(getRversion() <= "4.4.0") | ||
| expect_snapshot(get_layer_data(p), error = TRUE) | ||
| }) |
There was a problem hiding this comment.
Is it intended you put a test_that() call inside another test_that() call?
There was a problem hiding this comment.
Yes, that way I can conditionally skip a single expectation without throwing out all other expectations in a test. I improvised this to skip some snapshots on older R versions. This was due to error formatting that has changed across R versions.
thomasp85
approved these changes
Oct 30, 2024
|
Thanks for the review Thomas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #6155.
Marked as a draft for now as things are checked off.